Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev install fails without Jupyter lab #1012

Closed
jdemeyer opened this issue Jan 3, 2017 · 9 comments
Closed

Dev install fails without Jupyter lab #1012

jdemeyer opened this issue Jan 3, 2017 · 9 comments
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@jdemeyer
Copy link
Contributor

jdemeyer commented Jan 3, 2017

The relation between ipywidgets and jupyterlab is not so clear to me.

Is there a compelling reason why dev-install.sh requires Jupyterlab to be installed? I could easily change that script to skip the installation of jupyterlab_widgets if Jupyterlab is not installed. Would that be a good idea?

@SylvainCorlay
Copy link
Member

I think that it is the right thing to do to have the dev installation to require jupyterlab since it is the future main target environment for widgets.

Regarding the dependency order

A ipywidgets is the kernel-side package
B1 widgetsnbextension is the notebook-server-side notebook extension package (which could be in a different environement than the kernel)
B2 jupyterlab_widgets is the notebook-server-side lab extension package (which could be in a different environement than the kernel)

The logical dependency direction is that ipywidgets should be installable without widgetsnbextension of jupyterlab_widgets, and reversely.

However, we kept the feature that ipywidgets should be usable as a standalone package for someone who installs everything (kernel and client) in the same environment.

@jdemeyer
Copy link
Contributor Author

jdemeyer commented Jan 3, 2017

It's not a big issue, but I did find it surprising/confusing that ipywidgets itself does not require Jupyterlab, but the dev install does require Jupyterlab. Why not allow the option of doing the dev install without Jupyterlab for people who don't care about Jupyterlab?

@SylvainCorlay
Copy link
Member

Why not allow the option of doing the dev install without Jupyterlab for people who don't care about Jupyterlab?

For now, we don't depend on jupyterlab. This is only the dev-install script. To be honest, I don't use this script personally.

@jasongrout
Copy link
Member

I don't use the dev install script either. I did add the JLab stuff there to help someone else who was doing widgets in JLab. We could put the JLab stuff behind a switch if you want.

@hainm
Copy link

hainm commented Jan 3, 2017

if developers do not use it personally, why bothering to keep it to avoid confusion? :D

@SylvainCorlay
Copy link
Member

Some occasional contributors requested it :)

@hainm
Copy link

hainm commented Jan 3, 2017

ha, fair enough. I just wish all the Jupyter-related projects (Python+JS) have the same way to install packages for contributors.

@jdemeyer
Copy link
Contributor Author

jdemeyer commented Jan 5, 2017

We could put the JLab stuff behind a switch if you want.

See #1023.

@jasongrout
Copy link
Member

Fixed in #1023.

@jasongrout jasongrout modified the milestone: 6.0 Mar 1, 2017
@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

4 participants