New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev install fails without Jupyter lab #1012
Comments
I think that it is the right thing to do to have the dev installation to require jupyterlab since it is the future main target environment for widgets. Regarding the dependency order A The logical dependency direction is that ipywidgets should be installable without widgetsnbextension of jupyterlab_widgets, and reversely. However, we kept the feature that ipywidgets should be usable as a standalone package for someone who installs everything (kernel and client) in the same environment. |
It's not a big issue, but I did find it surprising/confusing that ipywidgets itself does not require Jupyterlab, but the dev install does require Jupyterlab. Why not allow the option of doing the dev install without Jupyterlab for people who don't care about Jupyterlab? |
For now, we don't depend on jupyterlab. This is only the dev-install script. To be honest, I don't use this script personally. |
I don't use the dev install script either. I did add the JLab stuff there to help someone else who was doing widgets in JLab. We could put the JLab stuff behind a switch if you want. |
if developers do not use it personally, why bothering to keep it to avoid confusion? :D |
Some occasional contributors requested it :) |
ha, fair enough. I just wish all the Jupyter-related projects (Python+JS) have the same way to install packages for contributors. |
See #1023. |
Fixed in #1023. |
The relation between ipywidgets and jupyterlab is not so clear to me.
Is there a compelling reason why
dev-install.sh
requires Jupyterlab to be installed? I could easily change that script to skip the installation ofjupyterlab_widgets
if Jupyterlab is not installed. Would that be a good idea?The text was updated successfully, but these errors were encountered: