Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat button for Play #1186

Closed
maartenbreddels opened this issue Mar 6, 2017 · 14 comments
Closed

Repeat button for Play #1186

maartenbreddels opened this issue Mar 6, 2017 · 14 comments
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@maartenbreddels
Copy link
Member

Some animation may benefit from having a repeat option, for instance here:
https://www.astro.rug.nl/~breddels/test/wave/
I'm not sure if a repeat button should always be shown, but I don't think it will hurt.

@jasongrout
Copy link
Member

A reverse button and maybe a speed of play button would also be interesting.

@maartenbreddels
Copy link
Member Author

Would be nice if these could be optional, to not clutter the gui.

@SylvainCorlay
Copy link
Member

@maartenbreddels PR welcome!

@maartenbreddels
Copy link
Member Author

Ok, but dev-install.sh often fails for me, a new clean clone might work again, I may try.

@SylvainCorlay
Copy link
Member

I don't actually use dev_install.sh!

@maartenbreddels
Copy link
Member Author

I always get the same, I start from a clean fork, everythings works. When I run npm run update from nbwidgetsextension a 2nd time, it fails running npm install file:../jupyter-js-widgets

air2 ~/src/ipywidgets/widgetsnbextension (master ✗)$ npm install file:../jupyter-js-widgets                                                                         ipywidgets-dev

> jupyter-js-widgets@2.1.4 prepublish /Users/maartenbreddels/src/ipywidgets/jupyter-js-widgets
> npm run build


> jupyter-js-widgets@2.1.4 build /Users/maartenbreddels/src/ipywidgets/jupyter-js-widgets
> npm run build:src && npm run build:src-embed && npm run build:css && webpack


> jupyter-js-widgets@2.1.4 build:src /Users/maartenbreddels/src/ipywidgets/jupyter-js-widgets
> tsc --project src

src/manager-base.ts(4,20): error TS2307: Cannot find module 'underscore'.
src/services-shim.ts(10,20): error TS2307: Cannot find module 'underscore'.
src/widget.ts(6,20): error TS2307: Cannot find module 'underscore'.
src/widget_bool.ts(16,20): error TS2307: Cannot find module 'underscore'.
src/widget_box.ts(33,20): error TS2307: Cannot find module 'underscore'.
src/widget_button.ts(20,20): error TS2307: Cannot find module 'underscore'.
src/widget_color.ts(12,20): error TS2307: Cannot find module 'underscore'.
src/widget_controller.ts(12,20): error TS2307: Cannot find module 'underscore'.
src/widget_core.ts(11,20): error TS2307: Cannot find module 'underscore'.
src/widget_date.ts(12,20): error TS2307: Cannot find module 'underscore'.
src/widget_float.ts(12,20): error TS2307: Cannot find module 'underscore'.
src/widget_image.ts(16,20): error TS2307: Cannot find module 'underscore'.
src/widget_int.ts(16,20): error TS2307: Cannot find module 'underscore'.
src/widget_layout.ts(12,20): error TS2307: Cannot find module 'underscore'.
src/widget_link.ts(12,20): error TS2307: Cannot find module 'underscore'.
src/widget_selection.ts(12,20): error TS2307: Cannot find module 'underscore'.
src/widget_selectioncontainer.ts(52,20): error TS2307: Cannot find module 'underscore'.
src/widget_string.ts(13,20): error TS2307: Cannot find module 'underscore'.
src/widget_style.ts(12,20): error TS2307: Cannot find module 'underscore'.

npm ERR! Darwin 14.5.0
npm ERR! argv "/Users/maartenbreddels/anaconda3/envs/ipywidgets-dev/bin/node" "/Users/maartenbreddels/anaconda3/envs/ipywidgets-dev/bin/npm" "run" "build:src"
npm ERR! node v4.4.0
npm ERR! npm  v2.14.20
npm ERR! code ELIFECYCLE
npm ERR! jupyter-js-widgets@2.1.4 build:src: `tsc --project src`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the jupyter-js-widgets@2.1.4 build:src script 'tsc --project src'.
npm ERR! This is most likely a problem with the jupyter-js-widgets package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     tsc --project src
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs jupyter-js-widgets
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! 
npm ERR!     npm owner ls jupyter-js-widgets
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/maartenbreddels/src/ipywidgets/jupyter-js-widgets/npm-debug.log

npm ERR! Darwin 14.5.0
npm ERR! argv "/Users/maartenbreddels/anaconda3/envs/ipywidgets-dev/bin/node" "/Users/maartenbreddels/anaconda3/envs/ipywidgets-dev/bin/npm" "run" "build"
npm ERR! node v4.4.0
npm ERR! npm  v2.14.20
npm ERR! code ELIFECYCLE
npm ERR! jupyter-js-widgets@2.1.4 build: `npm run build:src && npm run build:src-embed && npm run build:css && webpack`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the jupyter-js-widgets@2.1.4 build script 'npm run build:src && npm run build:src-embed && npm run build:css && webpack'.
npm ERR! This is most likely a problem with the jupyter-js-widgets package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run build:src && npm run build:src-embed && npm run build:css && webpack
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs jupyter-js-widgets
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! 
npm ERR!     npm owner ls jupyter-js-widgets
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/maartenbreddels/src/ipywidgets/jupyter-js-widgets/npm-debug.log

npm ERR! addLocal Could not install /Users/maartenbreddels/src/ipywidgets/jupyter-js-widgets
npm ERR! Darwin 14.5.0
npm ERR! argv "/Users/maartenbreddels/anaconda3/envs/ipywidgets-dev/bin/node" "/opt/local/bin/npm" "install" "file:../jupyter-js-widgets"
npm ERR! node v4.4.0
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR! jupyter-js-widgets@2.1.4 prepublish: `npm run build`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the jupyter-js-widgets@2.1.4 prepublish script 'npm run build'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the jupyter-js-widgets package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run build
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs jupyter-js-widgets
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls jupyter-js-widgets
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/maartenbreddels/src/ipywidgets/widgetsnbextension/npm-debug.log

Any idea?

@SylvainCorlay
Copy link
Member

Did you run npm install in jupyter-js-widgets?

@maartenbreddels
Copy link
Member Author

Yes, I get the same error. I even added "underscore": "^1.8.3" as devDependency, but i guess devDependencies includes dependencies

@maartenbreddels
Copy link
Member Author

I removed the jupyter-js-widgets/node_modules and after that it ran fine!

@dsblank
Copy link

dsblank commented Mar 16, 2017

A step button would be handy for play. I had to add a button (haven't made it look the same though):

screenshot-vsim

@SylvainCorlay
Copy link
Member

@dsblank great idea.

What is this screenshot?

@dsblank
Copy link

dsblank commented Mar 16, 2017

@SylvainCorlay Thanks... it would be useful for this project. This is a robot simulator written in pure Python. Here is a notebook in the Jyro repo:

https://github.com/Calysto/jyro/blob/master/docs/Visual%20Simulator.ipynb

Requires Jyro and Calysto (SVG graphics) libraries from git.

The library is designed for Deep Learning and Robots. I'm working on a book on this topic. Will come with a set of notebooks for readers to run their own experiments.

@jasongrout jasongrout added this to the Backlog milestone Apr 8, 2017
@gully
Copy link

gully commented May 3, 2018

It seems like this issue is closed now, yes? I see support for 🔁 repeat in Play in version 7.0.0, per the merged PR above. As for the step button, it looks like I can use my left and right arrow keys to increment by one step, albeit not in a GUI button.

@martinRenou
Copy link
Member

👍

@lock lock bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

6 participants