Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Select widget a scrolled list box again. #1238

Merged
merged 1 commit into from Mar 29, 2017
Merged

Make the Select widget a scrolled list box again. #1238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
40 changes: 25 additions & 15 deletions jupyter-js-widgets/src/widget_selection.ts
View file
Open in desktop
Expand Up @@ -36,17 +36,25 @@ class SelectionModel extends CoreLabeledDOMWidgetModel {
}

export
class SelectModel extends SelectionModel {
class DropdownModel extends SelectionModel {
defaults() {
return _.extend(super.defaults(), {
_model_name: 'SelectModel',
_view_name: 'SelectView'
_model_name: 'DropdownModel',
_view_name: 'DropdownView',
button_style: ''
});
}
}

// TODO: Make a phosphor dropdown control, wrapped in DropdownView. Also, fix
// bugs in keyboard handling. See
// https://github.com/jupyter-widgets/ipywidgets/issues/1055 and
// https://github.com/jupyter-widgets/ipywidgets/issues/1049
// For now, we subclass SelectView to provide DropdownView
// For the old code, see commit f68bfbc566f3a78a8f3350b438db8ed523ce3642

export
class SelectView extends LabeledDOMWidgetView {
class DropdownView extends LabeledDOMWidgetView {
/**
* Public constructor.
*/
Expand Down Expand Up @@ -117,25 +125,27 @@ class SelectView extends LabeledDOMWidgetView {
}



export
class DropdownModel extends SelectionModel {
class SelectModel extends SelectionModel {
defaults() {
return _.extend(super.defaults(), {
_model_name: 'DropdownModel',
_view_name: 'DropdownView',
button_style: ''
_model_name: 'SelectModel',
_view_name: 'SelectView'
});
}
}

// TODO: Make a phosphor dropdown control, wrapped in DropdownView. Also, fix
// bugs in keyboard handling. See
// https://github.com/jupyter-widgets/ipywidgets/issues/1055 and
// https://github.com/jupyter-widgets/ipywidgets/issues/1049
// For now, we subclass SelectView to provide DropdownView
// For the old code, see commit f68bfbc566f3a78a8f3350b438db8ed523ce3642
export
class DropdownView extends SelectView {}
class SelectView extends DropdownView {
/**
* Called when view is rendered.
*/
render() {
super.render();
this.listbox.setAttribute('size', '6');
}
}

export
class RadioButtonsModel extends SelectionModel {
Expand Down