Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kernel attribute check #3737

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Fix kernel attribute check #3737

merged 1 commit into from
Mar 27, 2023

Conversation

martinRenou
Copy link
Member

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch martinRenou/ipywidgets/fix_kernel_attr_check

@martinRenou martinRenou mentioned this pull request Mar 23, 2023
Closed
dllu
dllu approved these changes Mar 23, 2023
View reviewed changes
Copy link

@dllu dllu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TTianshun TTianshun mentioned this pull request Mar 25, 2023
Closed
@martinRenou
Copy link
Member Author

Thank you for the review. Merging as it's quite straightforward.

@martinRenou martinRenou merged commit 81736bb into jupyter-widgets:main Mar 27, 2023
@martinRenou martinRenou deleted the fix_kernel_attr_check branch March 27, 2023 07:46
@martinRenou
Copy link
Member Author

meeseeksdev please backport to 7.x

meeseeksmachine pushed a commit to meeseeksmachine/ipywidgets that referenced this pull request Mar 27, 2023
@martinRenou @meeseeksmachine
Backport PR jupyter-widgets#3737: Fix kernel attribute check
5bc92f9
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 27, 2023
Merged
martinRenou added a commit to meeseeksmachine/ipywidgets that referenced this pull request Mar 27, 2023
@martinRenou
Backport PR jupyter-widgets#3737: Fix kernel attribute check
c9b4f20
maartenbreddels pushed a commit that referenced this pull request Mar 28, 2023
@martinRenou @maartenbreddels
Backport PR #3737: Fix kernel attribute check
fa507e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dllu dllu dllu approved these changes

@maartenbreddels maartenbreddels Awaiting requested review from maartenbreddels

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot import in ipython 8.4.0: AttributeError: 'TerminalInteractiveShell' object has no attribute 'kernel'
2 participants
@martinRenou @dllu