Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fallback to lumino deepCopy rather than JSON.parse #3768

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: fallback to lumino deepCopy rather than JSON.parse #3768

wants to merge 2 commits into from

Conversation

naterush
Copy link

This PR fixes issue: #3701

You can test this by:

  1. Rendering a widget
  2. Using it as normal
  3. Opening your console and writing delete window.structuredClone
  4. Continuing to use the widget and seeing it still works as normal

I think this is a proper test, as I have verified that the serialize code is being called, and that it defaults to the correct function. Let me know if there is more to test though!

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch naterush/ipywidgets/fix_lumino_json_deepcopy

@maartenbreddels
Copy link
Member

hmm, do you understand the failure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@naterush @maartenbreddels