Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yarn version in dev installation documentation #3792

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

trungleduc
Copy link
Contributor

No description provided.

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch trungleduc/ipywidgets/update-dev-doc

@maartenbreddels
Copy link
Member

I thought we needed <2 everywhere, and this is also what is in https://github.com/jupyter-widgets/ipywidgets/blob/main/docs/source/dev_release.md and what I used for releasing.

@trungleduc
Copy link
Contributor Author

I saw It is bumped to version 3 in the readme in the last PR. The yarn 1 config file is also replaced with the yarn 3 one.

@ferdnyc
Copy link
Contributor

ferdnyc commented Aug 22, 2023

I saw It is bumped to version 3 in the readme in the last PR. The yarn 1 config file is also replaced with the yarn 3 one.

Yeah, actually the bump to requiring Yarn 3 was done in 8c08faf — I just updated the README and the Binder scripting to match, plus shook out some of the consequences of the change (like dropping a yarn plugin that's only compatible with version 1).

Looks like https://github.com/jupyter-widgets/ipywidgets/blob/main/docs/source/dev_release.md should be updated as well. Running yarn set version stable from the ipywidgets repo root directory will switch to using Yarn 3 locally, even on systems where the yarn command is otherwise version 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants