Merge pull request #232 from vidartf/fix-controls

Fix controls management
jupyter-widgets · Nov 5, 2018 · 03a509d · 03a509d
2 parents e7cd513 + 3b31442
commit 03a509d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/js/src/_base/Renderable.js b/js/src/_base/Renderable.js
@@ -395,11 +395,12 @@ var RenderableView = widgets.DOMWidgetView.extend({
 
     enableControls: function() {
         this.debug('Enable controls');
+        this.boundTick = this.tick.bind(this);
         var that = this;
         this.controls.forEach(function(control) {
             control.enabled = true;
             control.connectEvents(that.$renderer[0]);
-            control.addEventListener('change', that.tick.bind(that));
+            control.addEventListener('change', that.boundTick);
         });
     },
 
@@ -409,7 +410,7 @@ var RenderableView = widgets.DOMWidgetView.extend({
         this.controls.forEach(function(control) {
             control.enabled = false;
             control.dispose();  // Disconnect from DOM events
-            control.removeEventListener('change', that.tick.bind(that));
+            control.removeEventListener('change', that.boundTick);
         });
     },
 

diff --git a/js/src/core/Renderer.js b/js/src/core/Renderer.js
@@ -130,6 +130,7 @@ var RendererView = RenderableView.extend({
         this.model.get('controls').forEach(function (controlModel) {
             controls.push(controlModel.obj);
         });
+        this.controls = controls;
 
         if (!this.isFrozen) {
             this.enableControls();