Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix should_run_npm_install check function #41

Closed

Conversation

PytLab
Copy link

@PytLab PytLab commented Sep 26, 2018

Should check for package_json file, node_modules dir and npm
installation.

Should check for package_json file, node_modules dir and npm
installation.
@vidartf
Copy link
Member

vidartf commented Oct 4, 2018

I'm not sure if I follow the logic here: If the package.json file cannot be found, it should fail with an exception, as clearly something is misconfigured. The node_modules logic seem OK.

@vidartf
Copy link
Member

vidartf commented Oct 15, 2019

Note: A more modern solution here would be to use a PEP518 type pyproject.toml file, with a build dependency on jupyter_packaging.

@martinRenou
Copy link
Member

This code does not exist anymore, let's close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants