Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements what jupyter/notebook#3116 makes possible #9

Merged
merged 1 commit into from
Jan 9, 2018

Conversation

maartenbreddels
Copy link
Member

Enable nbextension at installation, only makes sense to merge when jupyter/notebook#3116 is merged.

@vidartf
Copy link
Member

vidartf commented Jan 8, 2018

I see jupyterlab (https://github.com/jupyterlab/jupyterlab/pull/3546/files) uses etc/jupyter/jupyter_notebook_config.d. Are there any guidelines for what path to use?

@bollwyvl
Copy link

bollwyvl commented Jan 9, 2018

So in that case, jupyterlab only needs to add itself as a serverextension, so it only adds a file to jupyter_notebook_config.json's counterpart, i.e. jupyter_notebook_config.d.

If you needed to add an nbextension, and add a serverextension, you might have:

jupyter-config/
  jupyter_notebook_config.d/
    my-extension.json
  nbconfig/
    notebook.d/
      my-extension.json

and the data_files would be something like:

('etc/jupyter/jupyter_notebook_config.d', 
 'jupyter-config/jupyter_notebook_config.d', 
 'my-extension.json'),
('etc/jupyter/nbconfig/notebook.d', 
 'jupyter-config/nbconfig/notebook.d', 
 'my-extension.json'),

How you lay it out on disk is up to you, but something like this structure will likely make it more maintainable as soon as you have more than one of them running around.

As to the actual name of the file... no hard and fast rule, but you know, unique.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants