Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve standalone test #109

Closed
MCWertGaming opened this issue Mar 11, 2021 · 4 comments
Closed

improve standalone test #109

MCWertGaming opened this issue Mar 11, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@MCWertGaming
Copy link
Collaborator

As my project broke (again) because the master master branch of cpp-terminal has functions which are not declared as static and included into two source files that get compiled together, I would like to add another source file to the stand-alone test to avoid such mistakes in the future.

@certik
Copy link
Collaborator

certik commented Mar 11, 2021

We should also probably move all functions into cpp and use the header file for declarations only. That should take care of this problem.

@MCWertGaming
Copy link
Collaborator Author

MCWertGaming commented Mar 11, 2021

Yeah exactly. I would like to do that and then add the optional compile options I have already collected and combine them with turning all warnings into errors (which will require some extra work as the integration tests throw some warnings already).

But I think that we should merge my open pull-requests before that as they can't be merged easily after such a huge change.

@certik
Copy link
Collaborator

certik commented Mar 11, 2021

Sure. I reviewed all of them now. Let me know if anything is not reviewed.

@MCWertGaming MCWertGaming mentioned this issue Mar 16, 2021
42 tasks
@MCWertGaming MCWertGaming added the enhancement New feature or request label Nov 23, 2021
@MCWertGaming MCWertGaming added this to To do in CPP-Terminal Dec 6, 2021
@MCWertGaming
Copy link
Collaborator Author

Fixed in #132. Closing this...

CPP-Terminal automation moved this from To do to Done Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants