-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitting the rest #132
Splitting the rest #132
Conversation
The changes are done now. Just have to test the library on windows. @certik could you test the example programs meanwhile on macos? The input would be the most important thing to test. |
I just tested a bit on macOS. The only issue I could find is that the prompt example, trying to add a new line with ALT+Enter ends the program with |
I have seen that too, but that was like this before. Also it's only after a few new lines - or is it directly causing a runtime error for you? |
The Alt-Enter has to be fixed, but that already happens in master:
So it is unrelated to this PR. |
This PR compiles fine and seem to work on Apple M1. However, the prompt example now starts in an empty screen. The behavior it should do is to start in the user terminal, like before. The full screen mode is tested by other examples such as |
Besides the prompt screen issue, the PR looks good to me, I went over it. Let's fix the prompt and after that I think we can merge and polish in master with subsequent PRs if needed. |
I'll fix the empty screen for the prompt example quickly. WIndows works fine! |
@certik the prompt is broken on windows. But in the master branch as well. That must be fixed as well. On runtime, I get the error: Debug Assertion Failed! in file minkernel/crts/ucrt/src/appcrt/convert/jsctype.cpp |
Also the reloading of the old screen is a bit broken somehow on windows. Will create Issues on those. |
I have created issues on the found problems. Once the unit tests continue, you should look one last tme over the changes and once you approve this PR, I'll merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prompt now works. I think this is good to merge as is.
Then we need to fix all bugs, on Windows as well as the alt-enter on a mac.
This PR splits the missing headers into source files and finally removes
base_terminal.h
andterminal.h
.