Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructure the header files #117

Closed
MCWertGaming opened this issue Mar 24, 2021 · 2 comments
Closed

restructure the header files #117

MCWertGaming opened this issue Mar 24, 2021 · 2 comments

Comments

@MCWertGaming
Copy link
Collaborator

Basically moving cpp-terminal's functions between the header files so the provided set of functions makes actually sense. This will also include cutting the BaseTerminal and Terminal classes so they actually make sense.

@MCWertGaming MCWertGaming mentioned this issue Mar 24, 2021
42 tasks
@MCWertGaming
Copy link
Collaborator Author

I have looked at the BaseTerminal and terminal classes and have thought about maybe split the classes into one class for preparing the terminal (base.hpp) and three functions for the input (input.cpp). The thing about moving the input into another files would be that the Windows class could call the preparation class itself int it's constructor and store it's object as private member. that would mean the user don't have to include both window.hpp and base.hpp.

The input class could be made into just functions and put into input.hpp. That would mean that we don't have to pass the object all the time to get user input. Also we don't have to include base.hpp all the time beacuse it needs to hold the Terminal class.

What do you think @certik? Is that a good idea or rather do a different approach here?

@MCWertGaming
Copy link
Collaborator Author

Fixed in #132.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant