Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default arguments like unicode to be automatically #153

Closed
Tracked by #114
MCWertGaming opened this issue Dec 6, 2021 · 2 comments · Fixed by #294
Closed
Tracked by #114

change default arguments like unicode to be automatically #153

MCWertGaming opened this issue Dec 6, 2021 · 2 comments · Fixed by #294
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@MCWertGaming
Copy link
Collaborator

MCWertGaming commented Dec 6, 2021

Currently, unicode has to be set manually - eiter on or off. I think that we should try to detect unicode support on runtime instead.

@MCWertGaming MCWertGaming mentioned this issue Dec 6, 2021
42 tasks
@MCWertGaming MCWertGaming self-assigned this Dec 6, 2021
@MCWertGaming MCWertGaming added the enhancement New feature or request label Dec 6, 2021
@MCWertGaming MCWertGaming added this to the V1.X.X milestone Dec 6, 2021
@MCWertGaming
Copy link
Collaborator Author

@flagarde
Copy link
Collaborator

flagarde commented Sep 16, 2023

@MCWertGaming this check locale support utf8 but terminal can be configured to use other encoding. I provide a very basic utf8 terminal support detection in #294, seems to work so far. I adapt the code to use it on windons*.cpp but it need more cleaning in other PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants