Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added github action to check if clang format was applied #138

Merged
merged 2 commits into from
Nov 23, 2021
Merged

added github action to check if clang format was applied #138

merged 2 commits into from
Nov 23, 2021

Conversation

MCWertGaming
Copy link
Collaborator

@MCWertGaming MCWertGaming commented Nov 23, 2021 •
edited

This PR adds a github action check that fails if clang-format wasn't applied. This will help to keep the code of the master branch clean. Fixes #92.

@MCWertGaming
Copy link
Collaborator Author

The clang-format action failed sucessfully.

certik
certik approved these changes Nov 23, 2021
View reviewed changes
Copy link
Collaborator

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great. Thanks for this PR.

@MCWertGaming MCWertGaming merged commit 1cd6a88 into jupyter-xeus:master Nov 23, 2021
@MCWertGaming MCWertGaming deleted the clangFormatAction branch November 23, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

checking of clang-format for pull-requests
2 participants
@MCWertGaming @certik