removed the get_term_size_slow() function #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCWertGaming
added
enhancement
|
Let's keep this PR open for a while. I want to do a thorough testing first on all platforms. We should enumerate the platforms we test and ensure things work everywhere (#73) before removing this. |
|
Sounds great! |
|
Let's change this into an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this removes the get_term_size_slow() function. We have already talked about that, I just wasn't sure if its needed. I mean like we have get_term_size(), wich is the same function but fast. But like I said, this is optional. I understand if we are keeping this for fall-back purposes.