Adding dotfiles #91
Merged
Adding dotfiles #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
certik
approved these changes
Feb 13, 2021
|
I have added clang-format. @certik you should check, if the coding style suits your preference. I have done the formating with clang-format in a seperate commit so I can just revert it, if you don't agree with it. |
Closed
|
What do you think @certik? I have to revert the last commit anyway to fix the merge conflicts |
|
The formatting looks good, it's very similar to what we already used before. Let's merge the other PRs first, then we can merge this one. |
|
Yeah, I thought the same coding style is a good thing. Also I really like the chromium coding standards. |
MCWertGaming
force-pushed
the
addDotFiles
branch
from
96b3cee
to
56311ca
Compare
|
I have resolved everything! now we can merge this and proceed with #67. |
|
Thanks, that looks good. I squashed your commits to make the history a bit tidier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request ties together #76 and #30 by adding the default .gitignore provided by github here and all config files used by visual studio community, visual studio code, Jetbrains CLion and generated files by cmake as standalone.
clang-format will follow as well. The discussing is ongoing in #30.