Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WASM build #530

Merged
merged 12 commits into from May 10, 2022
Merged

Add WASM build #530

merged 12 commits into from May 10, 2022

Conversation

DerThorsten
Copy link
Member

  • work in progress for jupyterlite / emscripten-forge dev.

@martinRenou martinRenou marked this pull request as draft May 6, 2022 13:03
@martinRenou
Copy link
Member

I am iterating on the CMakeLists to make a separate target for xeus-python-wasm

@martinRenou
Copy link
Member

@DerThorsten @JohanMabille I pushed some commits.

  • Add an interpreter_wasm class
  • Add a custom target for xeus-python-wasm (lib) and xpython_wasm (executable)
  • Added a CI job for compiling to wasm (cannot pass yet, we need to wait for the emscripten-forge)

martinRenou
martinRenou reviewed May 6, 2022
View reviewed changes
build_all.sh Outdated Show resolved Hide resolved
@martinRenou martinRenou changed the title wasm wip Add WASM build May 9, 2022
@martinRenou
Copy link
Member

@DerThorsten Github doesn't let me request a review from you, so I'm pinging you here :)

@martinRenou martinRenou force-pushed the wasm branch 2 times, most recently from 0d6800a to bd7a243 Compare May 9, 2022 14:42
@martinRenou
Copy link
Member

Rebased and now the CI passes 🚀

@martinRenou martinRenou marked this pull request as ready for review May 9, 2022 15:58
JohanMabille
JohanMabille requested changes May 9, 2022
View reviewed changes
Copy link
Member

@JohanMabille JohanMabille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some points are still unclear to me, let's discuss this tomorrow;

overwriteProp.cmake Outdated Show resolved Hide resolved
include/xeus-python/xinterpreter.hpp Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
patch_it.py Outdated Show resolved Hide resolved
post.js Outdated Show resolved Hide resolved
@martinRenou
Copy link
Member

martinRenou commented May 10, 2022 •
edited

Remaining points are:

@JohanMabille JohanMabille merged commit c5ac24a into jupyter-xeus:master May 10, 2022
@martinRenou
Copy link
Member

martinRenou added a commit to jupyterlite/xeus-python-kernel that referenced this pull request May 11, 2022
@martinRenou
Merge pull request #1 from martinRenou/remove_sleep
c8ab476 
Remove sleep + renames according to jupyter-xeus/xeus-python#530
DerThorsten pushed a commit to DerThorsten/xeus-python that referenced this pull request Nov 7, 2023
@martinRenou
Merge pull request #1 from martinRenou/remove_sleep
84eed71 
Remove sleep + renames according to jupyter-xeus#530
@anutosh491 anutosh491 mentioned this pull request Jan 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou left review comments

@JohanMabille JohanMabille JohanMabille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DerThorsten @martinRenou @JohanMabille