Skip to content

Commit

Permalink
Merge pull request #180 from JohanMabille/cleanup
Browse files Browse the repository at this point in the history
Removed unused member m_message_callback
  • Loading branch information
SylvainCorlay committed Jan 9, 2020
2 parents 189a879 + bddede1 commit 5d3b08d
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions include/xwidgets/xtransport.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,6 @@ namespace xw
{
public:

using message_callback_type = std::function<void(const nl::json&)>;

using derived_type = D;

derived_type& derived_cast() & noexcept;
Expand Down Expand Up @@ -165,7 +163,6 @@ namespace xw
const xeus::buffer_sequence&) const;

bool m_moved_from;
std::list<message_callback_type> m_message_callbacks;
const xeus::xmessage* m_hold;
xeus::xcomm m_comm;
};
Expand Down Expand Up @@ -228,7 +225,6 @@ namespace xw
template <class D>
inline xtransport<D>::xtransport(const xtransport& other)
: m_moved_from(false),
m_message_callbacks(other.m_message_callbacks),
m_hold(nullptr),
m_comm(other.m_comm)
{
Expand All @@ -239,7 +235,6 @@ namespace xw
template <class D>
inline xtransport<D>::xtransport(xtransport&& other)
: m_moved_from(false),
m_message_callbacks(std::move(other.m_message_callbacks)),
m_hold(nullptr),
m_comm(std::move(other.m_comm))
{
Expand All @@ -252,7 +247,6 @@ namespace xw
inline xtransport<D>& xtransport<D>::operator=(const xtransport& other)
{
m_moved_from = false;
m_message_callbacks = other.m_message_callbacks;
get_transport_registry().unregister(this->id());
m_hold = nullptr;
m_comm = other.m_comm;
Expand All @@ -266,7 +260,6 @@ namespace xw
{
other.m_moved_from = true;
m_moved_from = false;
m_message_callbacks = std::move(other.m_message_callbacks);
get_transport_registry().unregister(this->id());
m_hold = nullptr;
m_comm = std::move(other.m_comm);
Expand Down

0 comments on commit 5d3b08d

Please sign in to comment.