Skip to content

Commit

Permalink
Merge pull request #157 from ax3l/fix-docsQuotesCompilers
Browse files Browse the repository at this point in the history
Compiler Docs: Fix Quotes
  • Loading branch information
SylvainCorlay committed Sep 21, 2018
2 parents e8963bc + f7307a1 commit 9dc75c2
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions docs/source/compilers.rst
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,18 @@ interpreter.
However, with Visual Studio 2017, the introduction of ``__declspec(dllexport)``
instructions for certain widget types causes compilation errors. This is the
case for widget types that are used as properties for other widgets such as
``xlayout``` and style widgets.
``xlayout`` and style widgets.

The upstream `MSVC issue`_ issue appears to have been solved with VS2017 15.7
(Preview 3). The impacted build numbers for Visual Studio are
``_MSC_VER==1910``, ``_MSC_VER==1911```, ``_MSC_VER==1912```,
``_MSC_VER==1913```.
``_MSC_VER==1910``, ``_MSC_VER==1911``, ``_MSC_VER==1912``,
``_MSC_VER==1913``.

Visual Studio and CRTP bases
----------------------------

If we have ``template <class T> class Foo : public Bar<Foo<T>>``, then within
the implementation of ``Foo ``, ``Bar`` should be a template, and not refer to
the implementation of ``Foo``, ``Bar`` should be a template, and not refer to
``Bar<Foo<T>>``. However, unlike GCC and Clang, Visual Studio incorrectly makes
``Bar`` refer to the fully specialized template type.

Expand Down

0 comments on commit 9dc75c2

Please sign in to comment.