Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some missing widgets and test for missing ones #250

Merged
merged 5 commits into from
Feb 2, 2023
Merged

Fix some missing widgets and test for missing ones #250

merged 5 commits into from
Feb 2, 2023

Conversation

AntoinePrv
Copy link
Member

  • Add a test for missing wigets
  • Fix some error on currently available widgets.
  • Exclude widgets tracked in Missing widgets #249 from the test (so that we can use the test for now).

@AntoinePrv AntoinePrv mentioned this pull request Jan 26, 2023
Open
17 tasks
martinRenou
martinRenou approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martinRenou martinRenou merged commit 1cdc9f3 into jupyter-xeus:main Feb 2, 2023
@AntoinePrv AntoinePrv deleted the missing branch February 2, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AntoinePrv @martinRenou