This repository has been archived by the owner on Dec 29, 2017. It is now read-only.
Modify build system and closure dependencies #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulls out common functions into new library.
Use the Closure compiler to build a file called colab.dep that contains all the dependencies of the closure code. By including this file and specifying the namespaces to load, we avoid having to manually include the colab JS source files.
|
@minrk could you review this please? |
rgbkrk
added a commit
that referenced
this pull request
Mar 19, 2016
Modify build system and closure dependencies
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly refactors the build system, and changes the way closure source files are included.
Before, source files were included in html files manually. Now we generate a file, colab.dep, using the script build_closure_deps.py, which contains the dependency graph of the colab code. By including this file (as a js source file) and importing a single namespace, the closure library will automatically load all the dependencies of that namespace.
This requires re-running build_closure_deps.py when dependencies change, but this is much easier and more reliable than manually including the source files.