Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

In Layout mode, I really, REALLY want to drag and position cells by selecting anywhere in the cell. #52

Closed
jtyberg opened this issue Oct 26, 2015 · 14 comments
Labels

Comments

@jtyberg
Copy link
Member

jtyberg commented Oct 26, 2015

When positioning cells in Layout mode, I constantly find myself clicking and dragging the cell body to move cells, only to be reminded each time that it doesn't work that way. I then squint and locate the little move icon in the upper left corner of the cell and try again. 5 seconds later, I do the same for the next cell. Doh!

@dalogsdon
Copy link
Contributor

I agree that it is more intuitive to grab anywhere to drag. The reason there is a drag handle is that the cell output may contain widgets that are interactive, so we did not want the dragging to interfere with the interaction.

However, now that we have a 'View' mode in addition to a 'Layout' mode, we could use 'Layout' mode for dragging anywhere on the cell, blocking mouse interaction with any cell output. Then 'View' mode would allow interacting with the outputs of each cell.

@jtyberg
Copy link
Member Author

jtyberg commented Oct 27, 2015

I can't speak for everyone, but when I'm in Layout mode, I'm thinking about cell position and size. So I like the idea of favoring those interactions over interactions with widgets. I wonder what others think. I may be in the minority.

@parente
Copy link
Member

parente commented Oct 27, 2015

I've found myself interacting with a cell in layout mode to see if dynamic content fits in the cell or not. I'd go nuts flipping between layout and view to get that right.

@lbustelo
Copy link
Contributor

I'm not a fan of modes.

Maybe when you hover, a larger frame and drag target appears around that does not interfere with content.

Gino B.

On Oct 26, 2015, at 8:13 PM, Peter Parente notifications@github.com wrote:

I've found myself interacting with a cell in layout mode to see if dynamic content fits in the cell or not. I'd go nuts flipping between layout and view to get that right.


Reply to this email directly or view it on GitHub.

@Lull3rSkat3r
Copy link
Member

Can we put the drag handle around the entire border? Have the very edge be for resizing and have a small border for dragging. Now that I am writing it out seems a little wonky, but maybe will seed some innovation 🐮

@parente
Copy link
Member

parente commented Oct 27, 2015

Hotkey (Cmd) you hold while click/dragging to indicate "I want to move this" instead of "I want to interact with this"? Can be doc'ed somewhere / show up as a first time tooltip on drag?

@parente
Copy link
Member

parente commented Oct 27, 2015

Discussed that we should look into hotkey modifier approach with doc for it in a tooltip or something (to be opened separately). We will keep the current dragger icon too.

@dalogsdon
Copy link
Contributor

We will take the hotkey approach. Working on this with @jhpedemonte.

@jtyberg
Copy link
Member Author

jtyberg commented Oct 30, 2015

😂 👍

@dalogsdon
Copy link
Contributor

Hold the Shift key to be able to drag anywhere on a dashboard cell. Each cell will display the move icon to indicate this.

drag-cells-shift

@jtyberg Give it a try when PR #91 is merged.

🐙

@parente
Copy link
Member

parente commented Nov 2, 2015

Tested a bit. Confirmed that it doesn't have any effect in dashboard view or deployed dashboard (correct). Really tried to break it by holding shift while clicking outside browser and back to notebook mode. It does get "stuck" but pressing and releasing shift to reset things works fine.

@jtyberg Give feedback when you've got a chance to try it.

@jtyberg
Copy link
Member Author

jtyberg commented Nov 14, 2015

Very nice. Using the Shift key and dragging works just fine.

The only thing I noticed is the dragging a cell is a bit laggy when I've got a lot of cells (50+) in my notebook.

@dalogsdon
Copy link
Contributor

Yes, the layout is all absolute positioned, CPU intensive. The decision could be either to improve performance or recommend that a dashboard has less than X cells, since typical dashboards have maybe 10 at the most. Additionally, we could look into an interface such as tabbing to increase content while improving performance by moving cells to other (non-rendered) Gridstack instances.

@jhpedemonte
Copy link
Collaborator

Performance issues may be due to translucency. One solution may be to disable that in certain cases (lots of cells, slow machine, older browser, etc).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants