-
Notifications
You must be signed in to change notification settings - Fork 211
Deployed sibling polymer element can't find bower installed elements #78
Comments
We still need to take a look at jupyter/declarativewidgets#22 . It is strange that the relative urth_components path does not work. |
Test again. Various things have changed in dashboards (no more bower install) that might impact behavior. |
On current master, we moved the imports of the Polymer elements (iron-resizable-behavior, iron-list, paper-toggle-button and paper-material) to the top of By itself, that didn't work, since we ran into problem 2 from jupyter/declarativewidgets#22. So we added a forward slash before This works fine when running in Notebook, but breaks when running a deployed dashboard. But we get different errors than before: Related to @Lull3rSkat3r's deploy changes? |
This looks like Polymer is being loaded twice because of the multiple |
Try testing that locally deployed dashboard outside of Jupyter as a webserver. You can try this quickly on your Mac by:
and then hit http://localhost:8000/. The dashboard should load. I'd like to see if you get the same errors or different ones. |
Updated to latest widgets and moved imports into I no longer see the long list of errors, but the Upcoming Meetups list doesn't load correctly (when running in the notebook or deployed). It seems that it (eventually) gets the I tested the deployed dashboard using a non-Jupyter webserver and it works exactly as it does from Jupyter itself (and notebook) -- meaning, Upcoming Meetups list doesn't load, but candidates list does show when streaming. |
For the record, the demo is working around this problem by elevating the dependency links to the notebook from of in the widget HTML files. |
Back burnering until widget defect is resolved. |
This probably warrants retesting both with:
A short writeup on what works and what doesn't still is the first step. Might be a decl widgets issue still or might be a bundlers / dash server issue. |
Executing in the notebook, polymer.html itself raises status 404 errors for /urth_components/iron-list/iron-list.html, urth_components/paper-toggle-button/paper-toggle-button.html, and /urth_components/paper-material/paper-material.html. Locally deployed, meetup-outreach is initially disabled by https://github.com/jupyter-incubator/dashboards_bundlers/blob/master/dashboards_bundlers/local_deploy/__init__.py#L175 . With 0.5.2., |
When deployed locally, it's still 404s for |
Hm. Shouldn't be. Either the old version with the old path should work or the new one. Else we've got a backward compat bug that we shouldn't have.
I believe the README for decl widgets 0.5.2 says it will only work with ipywidgets 5.1.x and up. Our dev containers are still using ipywidgets 4.x and I think the README in bundlers says thebe only works with 4.x anyway. |
When the notebook server, kernel gateway, and dashboard server are running correctly, aside from a logged "Uncaught TypeError: Cannot read property 'register' of null", the dashboard works properly both deployed locally on the notebook server and on the dashboard server. |
Unless you plan to do more research, I think we can close this. |
Closing after manual test. |
For the Meetup Outreach demo, we moved some of our code out to HTML files which are siblings of the notebook file. We then import them like so:
The top of each of those HTML files has something like this:
This works well in the Notebook, but doesn't when we deploy. We get the following error:
The text was updated successfully, but these errors were encountered: