Add authentication from Auth0 #297
Conversation
|
Thanks for the contribution. Can you add a note about it on the auth wiki page so folks know how to use it? https://github.com/jupyter-incubator/dashboards_server/wiki/Authentication |
|
I don't have permission to edit the wiki. Should I write it in a markdown file? I could move the auth docs from the wiki to the repo and add the auth0 specifics. |
Oh wow. I thought the wiki used to be public read/write. I guess the default changed?
If you're feeling up to the task, that's very generous of you. Alternatively, you can drop the markdown here and I can do it. Or, if you're planning on contributing more over time, we can add you as a committer so you can update the wiki directly. |
|
I am not the best node dev but I am planning on using the dashboards more so that will probably include a couple of contributions. So if you can add me as a contributor I can add the docs to the wiki. |
|
Invite in the mail. |
| passport.authenticate('auth0', { failureRedirect: '/login' }), | ||
| function(req, res) { | ||
| if (!req.user) { | ||
| throw new Error('user null'); |
There was a problem hiding this comment.
Provide a more useful error message here, such as "User name must be set".
|
|
||
| app.post('/logout', function(req, res){ | ||
| req.logout(); | ||
| res.redirect('https://' + config.get('AUTH0_DOMAIN') + '/v2/logout?returnTo=' + config.get('PUBLIC_LINK_PATTERN') + '&client_id=' + config.get('AUTH0_CLIENT_ID')); |
There was a problem hiding this comment.
I think it's better to construct URLs using an API rather than string concatenation. In particular, this works around issues where a user may or may not append a '/'.
In other parts of the code, we've used url-join, but not sure how well it handles URL params. If that doesn't work, consider using Node.js' url.format().
There was a problem hiding this comment.
I ended up using node url.format as suggested.
Thanks! I added a small section to the wiki on Auth0. |
This PR adds a simple auth from Auth0.