Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Upgrade to Polymer v1.2 #62

Closed
purdrew opened this issue Oct 23, 2015 · 6 comments
Closed

Upgrade to Polymer v1.2 #62

purdrew opened this issue Oct 23, 2015 · 6 comments

Comments

@purdrew
Copy link
Contributor

purdrew commented Oct 23, 2015

Polymer v1.2 introduced a change to Polymer.Collection which introduces a # prefix to the keys in the collection. This is breaking our ability to set and retrieve data channel values correctly and results in ~37 failed unit tests. The Polymer change was introduced in commit Polymer/polymer@85d8a3a

Since Polymer.Collection is not a documented interface and it appears we are not using it as intended, we should probably consider other alternatives to prevent this from breaking us again in the future.

@peller
Copy link
Collaborator

peller commented Oct 23, 2015

There's ES6 Maps and Sets

@lbustelo
Copy link
Collaborator

There is another issue from elements getting updated to follow Polymer 1.2

chrome 46                ✖ elements/urth-viz-chart/test/urth-viz-chart.html » "before each" hook

  Polymer.dom(...).observeNodes is not a function
    <unknown> at     paper-input-container.Polymer.attached at /elements/paper-input/paper-input-container.html:461:0
    <unknown> at   paper-input-container.Polymer.Base._addFeature._invokeBehavior at /elements/polymer/polymer-micro.html:356:0
    <unknown> at   paper-input-container.Polymer.Base._addFeature._doBehavior at /elements/polymer/polymer-micro.html:351:0
    <unknown> at          paper-input-container.<anonymous> at /elements/polymer/polymer-micro.html:156:0
    <unknown> at      Object.Polymer.RenderStatus.whenReady at /elements/polymer/polymer-micro.html:109:0
    <unknown> at   paper-input-container.Polymer.Base.attachedCallback at /elements/polymer/polymer-micro.html:154:0
    <unknown> at   paper-input-container.Polymer.Base._addFeature.attachedCallback at /elements/polymer/polymer-mini.html:96:0
    <unknown> at   test-fixture.TestFixtureExtension.createFrom at /elements/test-fixture/test-fixture.html:70:0
    <unknown> at                   test-fixture.<anonymous> at /elements/test-fixture/test-fixture.html:38:0```

@lbustelo
Copy link
Collaborator

We are not on Polymer 1.2. Staying on 1.1.x was not working.
/cc @jhpedemonte @parente @Lull3rSkat3r

@parente
Copy link
Member

parente commented Oct 29, 2015

We are not on Polymer 1.2.

OK

Staying on 1.1.x was not working.

So ... what are you on?

@lbustelo
Copy link
Collaborator

It's late man... We are on 1.2

@parente
Copy link
Member

parente commented Oct 29, 2015

No more bugs for you! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants