This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Moved dynamic-list out of meetup outreach notebook.
#79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also created a new Polymer element for upcoming meetups list and externalized it as well. :chicken: (c) Copyright IBM Corp. 2015
|
Currently deploying doesn't work because we are installing Polymer 1.2 when deploying. |
parente
changed the title
dynamic-list out of meetup outreach notebook.dynamic-list out of meetup outreach notebook.
|
So we shouldn't merge this until the deploy works. |
|
The deploy issue is unrelated to the Meetup outreach notebook changes. It happens with the current version as well. |
parente
changed the title
dynamic-list out of meetup outreach notebook.dynamic-list out of meetup outreach notebook.
|
Can you test again now that widgets moved to 1.2 to make sure everything works correctly when deployed? |
|
It is working now with the widgets update to Polymer 1.2. |
parente
added a commit
that referenced
this pull request
Oct 29, 2015
Moved `dynamic-list` out of meetup outreach notebook.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also created a new Polymer element for upcoming meetups list and externalized it as well.
Fixes #71
Fixes #58
馃悢