Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated brand guidelines #58

Merged
merged 1 commit into from Jul 22, 2019
Merged

Updated brand guidelines #58

merged 1 commit into from Jul 22, 2019

Conversation

i-am-am
Copy link
Contributor

@i-am-am i-am-am commented May 14, 2019

  • Moved unused files to archive
  • Finished Powered by Jupyter logos
  • Updated brand guidelines

@Zsailer
Copy link
Member

Zsailer commented Jun 4, 2019

@i-am-am thank you for working on this new draft of the brand guidelines!

A lot of files have moved, making it difficult to review just the new stuff you've added in the git diff.

Would you mind listing here the files that are new or changed (not the ones that are renamed/moved/removed). That will make it easier for review.

@i-am-am
Copy link
Contributor Author

i-am-am commented Jun 4, 2019

The only files that have changed, not removed or moved, are:

  • brandguide/brand_guide.pdf

  • Some small changes in both Rectangle and Square Powered by Jupyter logos to make sure everything is aligned and colors are correct

@tgeorgeux tgeorgeux self-requested a review June 18, 2019 02:00
tgeorgeux
tgeorgeux approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@tgeorgeux tgeorgeux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These updates look great! I am confident we will continue to iterate on the space filler and add some templates for associated logo use but if nobody is opposed I would love to merge and iterate on this.

@Carreau Carreau merged commit d88f97b into jupyter:master Jul 22, 2019
@Carreau
Copy link
Member

Carreau commented Jul 22, 2019

@tgeorgeux not quite sure what you could not merge; works for me. I'll try to add you as a top-level collaborator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgeorgeux tgeorgeux tgeorgeux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@i-am-am @Zsailer @Carreau @tgeorgeux