Merge pull request #1672 from mathbunnyru/asalikhov/remove_warning

Remove JUPYTER_ENABLE_LAB variable warning
jupyter · Apr 5, 2022 · 068e3c5 · 068e3c5
2 parents b4a0fc5 + 722d5c3
commit 068e3c5
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 10 deletions.
diff --git a/base-notebook/start-notebook.sh b/base-notebook/start-notebook.sh
@@ -18,9 +18,5 @@ if [[ "${RESTARTABLE}" == "yes" ]]; then
     wrapper="run-one-constantly"
 fi
 
-if [[ -v JUPYTER_ENABLE_LAB ]]; then
-    echo "WARNING: JUPYTER_ENABLE_LAB is ignored, use DOCKER_STACKS_JUPYTER_CMD if you want to change the command used to start the server"
-fi
-
 # shellcheck disable=SC1091,SC2086
 exec /usr/local/bin/start.sh ${wrapper} jupyter ${DOCKER_STACKS_JUPYTER_CMD} ${NOTEBOOK_ARGS} "$@"
diff --git a/tests/base-notebook/test_start_container.py b/tests/base-notebook/test_start_container.py
@@ -15,12 +15,6 @@
 @pytest.mark.parametrize(
     "env,expected_command,expected_start,expected_warnings",
     [
-        (
-            ["JUPYTER_ENABLE_LAB=yes"],
-            "jupyter lab",
-            True,
-            ["WARNING: JUPYTER_ENABLE_LAB is ignored"],
-        ),
         (None, "jupyter lab", True, []),
         (["DOCKER_STACKS_JUPYTER_CMD=lab"], "jupyter lab", True, []),
         (["RESTARTABLE=yes"], "run-one-constantly jupyter lab", True, []),