Fix using inputs in actions: use lowercase input ids, remove types, f…

…ix bool checks
jupyter · Nov 5, 2023 · 2d640b3 · 2d640b3
1 parent eac7571
commit 2d640b3
Show file tree

Hide file tree

Showing 3 changed files with 74 additions and 79 deletions.
diff --git a/.github/actions/download-manifests/action.yml b/.github/actions/download-manifests/action.yml
@@ -6,18 +6,15 @@ description: Download all manifests and history lines
 # https://github.com/actions/download-artifact/issues/6
 
 inputs:
-  histLineDir:
+  hist-line-dir:
     description: Directory to store history lines
     required: true
-    type: string
-  manifestDir:
+  manifest-dir:
     description: Directory to store manifest files
     required: true
-    type: string
-  fastBuild:
+  fast-build:
     description: Only build docker-stacks-foundation and base-notebook
     required: true
-    type: boolean
 
 runs:
   using: composite
@@ -26,220 +23,220 @@ runs:
       uses: actions/download-artifact@v3
       with:
         name: docker-stacks-foundation-aarch64-history_line
-        path: ${{ inputs.histLineDir }}
+        path: ${{ inputs.hist-line-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
       with:
         name: docker-stacks-foundation-x86_64-history_line
-        path: ${{ inputs.histLineDir }}
+        path: ${{ inputs.hist-line-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
       with:
         name: base-notebook-aarch64-history_line
-        path: ${{ inputs.histLineDir }}
+        path: ${{ inputs.hist-line-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
       with:
         name: base-notebook-x86_64-history_line
-        path: ${{ inputs.histLineDir }}
+        path: ${{ inputs.hist-line-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: minimal-notebook-aarch64-history_line
-        path: ${{ inputs.histLineDir }}
+        path: ${{ inputs.hist-line-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: minimal-notebook-x86_64-history_line
-        path: ${{ inputs.histLineDir }}
+        path: ${{ inputs.hist-line-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: scipy-notebook-aarch64-history_line
-        path: ${{ inputs.histLineDir }}
+        path: ${{ inputs.hist-line-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: scipy-notebook-x86_64-history_line
-        path: ${{ inputs.histLineDir }}
+        path: ${{ inputs.hist-line-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: r-notebook-aarch64-history_line
-        path: ${{ inputs.histLineDir }}
+        path: ${{ inputs.hist-line-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: r-notebook-x86_64-history_line
-        path: ${{ inputs.histLineDir }}
+        path: ${{ inputs.hist-line-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: julia-notebook-aarch64-history_line
-        path: ${{ inputs.histLineDir }}
+        path: ${{ inputs.hist-line-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: julia-notebook-x86_64-history_line
-        path: ${{ inputs.histLineDir }}
+        path: ${{ inputs.hist-line-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: tensorflow-notebook-aarch64-history_line
-        path: ${{ inputs.histLineDir }}
+        path: ${{ inputs.hist-line-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: tensorflow-notebook-x86_64-history_line
-        path: ${{ inputs.histLineDir }}
+        path: ${{ inputs.hist-line-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: datascience-notebook-aarch64-history_line
-        path: ${{ inputs.histLineDir }}
+        path: ${{ inputs.hist-line-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: datascience-notebook-x86_64-history_line
-        path: ${{ inputs.histLineDir }}
+        path: ${{ inputs.hist-line-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: pyspark-notebook-aarch64-history_line
-        path: ${{ inputs.histLineDir }}
+        path: ${{ inputs.hist-line-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: pyspark-notebook-x86_64-history_line
-        path: ${{ inputs.histLineDir }}
+        path: ${{ inputs.hist-line-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: all-spark-notebook-aarch64-history_line
-        path: ${{ inputs.histLineDir }}
+        path: ${{ inputs.hist-line-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: all-spark-notebook-x86_64-history_line
-        path: ${{ inputs.histLineDir }}
+        path: ${{ inputs.hist-line-dir }}
 
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
       with:
         name: docker-stacks-foundation-aarch64-manifest
-        path: ${{ inputs.manifestDir }}
+        path: ${{ inputs.manifest-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
       with:
         name: docker-stacks-foundation-x86_64-manifest
-        path: ${{ inputs.manifestDir }}
+        path: ${{ inputs.manifest-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
       with:
         name: base-notebook-aarch64-manifest
-        path: ${{ inputs.manifestDir }}
+        path: ${{ inputs.manifest-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
       with:
         name: base-notebook-x86_64-manifest
-        path: ${{ inputs.manifestDir }}
+        path: ${{ inputs.manifest-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: minimal-notebook-aarch64-manifest
-        path: ${{ inputs.manifestDir }}
+        path: ${{ inputs.manifest-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: minimal-notebook-x86_64-manifest
-        path: ${{ inputs.manifestDir }}
+        path: ${{ inputs.manifest-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: scipy-notebook-aarch64-manifest
-        path: ${{ inputs.manifestDir }}
+        path: ${{ inputs.manifest-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: scipy-notebook-x86_64-manifest
-        path: ${{ inputs.manifestDir }}
+        path: ${{ inputs.manifest-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: r-notebook-aarch64-manifest
-        path: ${{ inputs.manifestDir }}
+        path: ${{ inputs.manifest-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: r-notebook-x86_64-manifest
-        path: ${{ inputs.manifestDir }}
+        path: ${{ inputs.manifest-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: tensorflow-notebook-aarch64-manifest
-        path: ${{ inputs.manifestDir }}
+        path: ${{ inputs.manifest-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: tensorflow-notebook-x86_64-manifest
-        path: ${{ inputs.manifestDir }}
+        path: ${{ inputs.manifest-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: datascience-notebook-aarch64-manifest
-        path: ${{ inputs.manifestDir }}
+        path: ${{ inputs.manifest-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: datascience-notebook-x86_64-manifest
-        path: ${{ inputs.manifestDir }}
+        path: ${{ inputs.manifest-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: pyspark-notebook-aarch64-manifest
-        path: ${{ inputs.manifestDir }}
+        path: ${{ inputs.manifest-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: pyspark-notebook-x86_64-manifest
-        path: ${{ inputs.manifestDir }}
+        path: ${{ inputs.manifest-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: all-spark-notebook-aarch64-manifest
-        path: ${{ inputs.manifestDir }}
+        path: ${{ inputs.manifest-dir }}
     - name: Download artifact 📥
       uses: actions/download-artifact@v3
-      if: ${{ !inputs.fastBuild }}
+      if: ${{ !inputs.fast-build == 'true' }}
       with:
         name: all-spark-notebook-x86_64-manifest
-        path: ${{ inputs.manifestDir }}
+        path: ${{ inputs.manifest-dir }}
diff --git a/.github/actions/load-image/action.yml b/.github/actions/load-image/action.yml
@@ -5,11 +5,9 @@ inputs:
   image:
     description: Image name
     required: true
-    type: string
   platform:
     description: Image platform
     required: true
-    type: string
 
 runs:
   using: composite

diff --git a/.github/workflows/docker-wiki-update.yml b/.github/workflows/docker-wiki-update.yml
@@ -21,9 +21,9 @@ jobs:
       - name: Download all manifests and history lines 📥
         uses: ./.github/actions/download-manifests
         with:
-          histLineDir: /tmp/jupyter/hist_lines/
-          manifestDir: /tmp/jupyter/manifests/
-          fastBuild: ${{ contains(github.event.pull_request.title, '[FAST_BUILD]') }}
+          hist-line-dir: /tmp/jupyter/hist_lines/
+          manifest-dir: /tmp/jupyter/manifests/
+          fast-build: ${{ contains(github.event.pull_request.title, '[FAST_BUILD]') }}
       - name: Display structure of downloaded files 🔍️
         run: |
           ls -R /tmp/jupyter/hist_lines/