Move all images to images dir (#1972)

jupyter · Aug 19, 2023 · a5b40a6 · a5b40a6
1 parent feb8872
commit a5b40a6
Show file tree

Hide file tree

Showing 46 changed files with 7 additions and 36 deletions.
diff --git a/.github/workflows/docker-build-test-upload.yml b/.github/workflows/docker-build-test-upload.yml
@@ -60,7 +60,7 @@ jobs:
         shell: bash
 
       - name: Build image 🛠
-        run: docker build --rm --force-rm --tag ${{ env.OWNER }}/${{ inputs.image }} ${{ inputs.image }}/
+        run: docker build --rm --force-rm --tag ${{ env.OWNER }}/${{ inputs.image }} images/${{ inputs.image }}/
         env:
           DOCKER_BUILDKIT: 1
           # Full logs for CI build

diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml
@@ -20,17 +20,7 @@ on:
       - ".github/actions/download-manifests/action.yml"
       - ".github/actions/load-image/action.yml"
 
-      - "all-spark-notebook/**"
-      - "base-notebook/**"
-      - "datascience-notebook/**"
-      - "docker-stacks-foundation/**"
-      - "julia-notebook/**"
-      - "minimal-notebook/**"
-      - "pyspark-notebook/**"
-      - "r-notebook/**"
-      - "scipy-notebook/**"
-      - "tensorflow-notebook/**"
-
+      - "images/**"
       - "tagging/**"
       - "tests/**"
       - "requirements-dev.txt"
@@ -48,17 +38,7 @@ on:
       - ".github/actions/download-manifests/action.yml"
       - ".github/actions/load-image/action.yml"
 
-      - "all-spark-notebook/**"
-      - "base-notebook/**"
-      - "datascience-notebook/**"
-      - "docker-stacks-foundation/**"
-      - "julia-notebook/**"
-      - "minimal-notebook/**"
-      - "pyspark-notebook/**"
-      - "r-notebook/**"
-      - "scipy-notebook/**"
-      - "tensorflow-notebook/**"
-
+      - "images/**"
       - "tagging/**"
       - "tests/**"
       - "requirements-dev.txt"

diff --git a/.github/workflows/hub-overview.yml b/.github/workflows/hub-overview.yml
@@ -10,16 +10,7 @@ on:
     paths:
       - ".github/workflows/hub-overview.yml"
 
-      - "all-spark-notebook/README.md"
-      - "base-notebook/README.md"
-      - "datascience-notebook/README.md"
-      - "docker-stacks-foundation/README.md"
-      - "julia-notebook/README.md"
-      - "minimal-notebook/README.md"
-      - "pyspark-notebook/README.md"
-      - "r-notebook/README.md"
-      - "scipy-notebook/README.md"
-      - "tensorflow-notebook/README.md"
+      - "images/*/README.md"
 
 jobs:
   update-dockerhub-overview:
@@ -40,7 +31,7 @@ jobs:
           destination_container_repo: ${{ env.OWNER }}/${{ matrix.image }}
           provider: dockerhub
           short_description: ${{ matrix.description }}
-          readme_file: ${{ matrix.image }}/README.md
+          readme_file: images/${{ matrix.image }}/README.md
 
     strategy:
       matrix:

diff --git a/Makefile b/Makefile
@@ -37,7 +37,7 @@ help:
 
 build/%: DOCKER_BUILD_ARGS?=
 build/%: ## build the latest image for a stack using the system's architecture
-	docker build $(DOCKER_BUILD_ARGS) --rm --force-rm --tag "$(OWNER)/$(notdir $@):latest" "./$(notdir $@)" --build-arg OWNER="$(OWNER)"
+	docker build $(DOCKER_BUILD_ARGS) --rm --force-rm --tag "$(OWNER)/$(notdir $@):latest" "./images/$(notdir $@)" --build-arg OWNER="$(OWNER)"
 	@echo -n "Built image size: "
 	@docker images "$(OWNER)/$(notdir $@):latest" --format "{{.Size}}"
 build-all: $(foreach I, $(ALL_IMAGES), build/$(I)) ## build all stacks

diff --git a/all-spark-notebook/.dockerignore → images/all-spark-notebook/.dockerignore b/all-spark-notebook/.dockerignore → images/all-spark-notebook/.dockerignore
diff --git a/all-spark-notebook/Dockerfile → images/all-spark-notebook/Dockerfile b/all-spark-notebook/Dockerfile → images/all-spark-notebook/Dockerfile
diff --git a/all-spark-notebook/README.md → images/all-spark-notebook/README.md b/all-spark-notebook/README.md → images/all-spark-notebook/README.md
diff --git a/base-notebook/.dockerignore → images/base-notebook/.dockerignore b/base-notebook/.dockerignore → images/base-notebook/.dockerignore
diff --git a/base-notebook/Dockerfile → images/base-notebook/Dockerfile b/base-notebook/Dockerfile → images/base-notebook/Dockerfile
diff --git a/base-notebook/README.md → images/base-notebook/README.md b/base-notebook/README.md → images/base-notebook/README.md
diff --git a/base-notebook/docker_healthcheck.py → images/base-notebook/docker_healthcheck.py b/base-notebook/docker_healthcheck.py → images/base-notebook/docker_healthcheck.py
diff --git a/base-notebook/jupyter_server_config.py → ...es/base-notebook/jupyter_server_config.py b/base-notebook/jupyter_server_config.py → ...es/base-notebook/jupyter_server_config.py
diff --git a/base-notebook/start-notebook.sh → images/base-notebook/start-notebook.sh b/base-notebook/start-notebook.sh → images/base-notebook/start-notebook.sh
diff --git a/base-notebook/start-singleuser.sh → images/base-notebook/start-singleuser.sh b/base-notebook/start-singleuser.sh → images/base-notebook/start-singleuser.sh
diff --git a/datascience-notebook/.dockerignore → images/datascience-notebook/.dockerignore b/datascience-notebook/.dockerignore → images/datascience-notebook/.dockerignore
diff --git a/datascience-notebook/Dockerfile → images/datascience-notebook/Dockerfile b/datascience-notebook/Dockerfile → images/datascience-notebook/Dockerfile
diff --git a/datascience-notebook/README.md → images/datascience-notebook/README.md b/datascience-notebook/README.md → images/datascience-notebook/README.md
diff --git a/docker-stacks-foundation/.dockerignore → ...es/docker-stacks-foundation/.dockerignore b/docker-stacks-foundation/.dockerignore → ...es/docker-stacks-foundation/.dockerignore
diff --git a/docker-stacks-foundation/Dockerfile → images/docker-stacks-foundation/Dockerfile b/docker-stacks-foundation/Dockerfile → images/docker-stacks-foundation/Dockerfile
diff --git a/docker-stacks-foundation/README.md → images/docker-stacks-foundation/README.md b/docker-stacks-foundation/README.md → images/docker-stacks-foundation/README.md
diff --git a/docker-stacks-foundation/fix-permissions → .../docker-stacks-foundation/fix-permissions b/docker-stacks-foundation/fix-permissions → .../docker-stacks-foundation/fix-permissions
diff --git a/docker-stacks-foundation/initial-condarc → .../docker-stacks-foundation/initial-condarc b/docker-stacks-foundation/initial-condarc → .../docker-stacks-foundation/initial-condarc
diff --git a/docker-stacks-foundation/start.sh → images/docker-stacks-foundation/start.sh b/docker-stacks-foundation/start.sh → images/docker-stacks-foundation/start.sh
diff --git a/julia-notebook/.dockerignore → images/julia-notebook/.dockerignore b/julia-notebook/.dockerignore → images/julia-notebook/.dockerignore
diff --git a/julia-notebook/Dockerfile → images/julia-notebook/Dockerfile b/julia-notebook/Dockerfile → images/julia-notebook/Dockerfile
diff --git a/julia-notebook/README.md → images/julia-notebook/README.md b/julia-notebook/README.md → images/julia-notebook/README.md
diff --git a/minimal-notebook/.dockerignore → images/minimal-notebook/.dockerignore b/minimal-notebook/.dockerignore → images/minimal-notebook/.dockerignore
diff --git a/minimal-notebook/Dockerfile → images/minimal-notebook/Dockerfile b/minimal-notebook/Dockerfile → images/minimal-notebook/Dockerfile
diff --git a/minimal-notebook/README.md → images/minimal-notebook/README.md b/minimal-notebook/README.md → images/minimal-notebook/README.md
diff --git a/minimal-notebook/Rprofile.site → images/minimal-notebook/Rprofile.site b/minimal-notebook/Rprofile.site → images/minimal-notebook/Rprofile.site
diff --git a/...k/setup-scripts/setup-julia-packages.bash → ...k/setup-scripts/setup-julia-packages.bash b/...k/setup-scripts/setup-julia-packages.bash → ...k/setup-scripts/setup-julia-packages.bash
diff --git a/...l-notebook/setup-scripts/setup-julia.bash → ...l-notebook/setup-scripts/setup-julia.bash b/...l-notebook/setup-scripts/setup-julia.bash → ...l-notebook/setup-scripts/setup-julia.bash
diff --git a/pyspark-notebook/.dockerignore → images/pyspark-notebook/.dockerignore b/pyspark-notebook/.dockerignore → images/pyspark-notebook/.dockerignore
diff --git a/pyspark-notebook/Dockerfile → images/pyspark-notebook/Dockerfile b/pyspark-notebook/Dockerfile → images/pyspark-notebook/Dockerfile
diff --git a/pyspark-notebook/README.md → images/pyspark-notebook/README.md b/pyspark-notebook/README.md → images/pyspark-notebook/README.md
diff --git a/pyspark-notebook/ipython_kernel_config.py → ...pyspark-notebook/ipython_kernel_config.py b/pyspark-notebook/ipython_kernel_config.py → ...pyspark-notebook/ipython_kernel_config.py
diff --git a/r-notebook/.dockerignore → images/r-notebook/.dockerignore b/r-notebook/.dockerignore → images/r-notebook/.dockerignore
diff --git a/r-notebook/Dockerfile → images/r-notebook/Dockerfile b/r-notebook/Dockerfile → images/r-notebook/Dockerfile
diff --git a/r-notebook/README.md → images/r-notebook/README.md b/r-notebook/README.md → images/r-notebook/README.md
diff --git a/scipy-notebook/.dockerignore → images/scipy-notebook/.dockerignore b/scipy-notebook/.dockerignore → images/scipy-notebook/.dockerignore
diff --git a/scipy-notebook/Dockerfile → images/scipy-notebook/Dockerfile b/scipy-notebook/Dockerfile → images/scipy-notebook/Dockerfile
diff --git a/scipy-notebook/README.md → images/scipy-notebook/README.md b/scipy-notebook/README.md → images/scipy-notebook/README.md
diff --git a/tensorflow-notebook/.dockerignore → images/tensorflow-notebook/.dockerignore b/tensorflow-notebook/.dockerignore → images/tensorflow-notebook/.dockerignore
diff --git a/tensorflow-notebook/Dockerfile → images/tensorflow-notebook/Dockerfile b/tensorflow-notebook/Dockerfile → images/tensorflow-notebook/Dockerfile
diff --git a/tensorflow-notebook/README.md → images/tensorflow-notebook/README.md b/tensorflow-notebook/README.md → images/tensorflow-notebook/README.md
diff --git a/tagging/write_manifest.py b/tagging/write_manifest.py
@@ -38,7 +38,7 @@ def write_build_history_line(
     links_column = MARKDOWN_LINE_BREAK.join(
         [
             f"[Git diff](https://github.com/jupyter/docker-stacks/commit/{commit_hash})",
-            f"[Dockerfile](https://github.com/jupyter/docker-stacks/blob/{commit_hash}/{short_image_name}/Dockerfile)",
+            f"[Dockerfile](https://github.com/jupyter/docker-stacks/blob/{commit_hash}/images/{short_image_name}/Dockerfile)",
             f"[Build manifest](./{filename})",
         ]
     )