Skip to content

Commit

Permalink
Build images with ubuntu-22.04 and python-3.7
Browse files Browse the repository at this point in the history
  • Loading branch information
mathbunnyru committed Oct 9, 2022
1 parent f307980 commit b867533
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions base-notebook/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# Copyright (c) Jupyter Development Team.
# Distributed under the terms of the Modified BSD License.

# Ubuntu 20.04 (focal)
# https://hub.docker.com/_/ubuntu/tags?page=1&name=focal
ARG ROOT_CONTAINER=ubuntu:20.04
# Ubuntu 22.04 (jammy)
# https://hub.docker.com/_/ubuntu/tags?page=1&name=jammy
ARG ROOT_CONTAINER=ubuntu:22.04

FROM $ROOT_CONTAINER

Expand Down Expand Up @@ -85,7 +85,7 @@ RUN echo "auth requisite pam_deny.so" >> /etc/pam.d/su && \
USER ${NB_UID}

# Pin python version here, or set it to "default"
ARG PYTHON_VERSION=3.10
ARG PYTHON_VERSION=3.7

# Setup work directory for backward-compatibility
RUN mkdir "/home/${NB_USER}/work" && \
Expand Down
2 changes: 1 addition & 1 deletion tests/base-notebook/test_python.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from tests.conftest import TrackedContainer

LOGGER = logging.getLogger(__name__)
EXPECTED_PYTHON_VERSION = "3.10"
EXPECTED_PYTHON_VERSION = "3.7"


def test_python_version(container: TrackedContainer) -> None:
Expand Down

0 comments on commit b867533

Please sign in to comment.