Skip to content

Commit

Permalink
Install nodejs >= 18.0 (#1902)
Browse files Browse the repository at this point in the history
* Install nodejs >= 18.0

NodeJS >= 18.0 requires `jupyter lab build` command.

Fixes #1901.

* Update Dockerfile

* Update Dockerfile

* Update test_packages.py

---------

Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
  • Loading branch information
mrkn and mathbunnyru committed May 26, 2023
1 parent a2f462b commit e98be3d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions base-notebook/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ USER ${NB_UID}
# files across image layers when the permissions change
WORKDIR /tmp
RUN mamba install --yes \
# NodeJS >= 18.0 is required for `jupyter lab build` command
# https://github.com/jupyter/docker-stacks/issues/1901
'nodejs>=18.0' \
'notebook' \
'jupyterhub' \
'jupyterlab' && \
Expand Down
1 change: 1 addition & 0 deletions tests/base-notebook/test_packages.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@
"hdf5",
"jupyter_server[version='>", # Temporary fix for: https://github.com/jupyter/docker-stacks/issues/1851
"jupyterlab-git",
"nodejs[version='>", # Temporary fix for: https://github.com/jupyter/docker-stacks/issues/1901
"openssl",
"protobuf",
"python",
Expand Down

0 comments on commit e98be3d

Please sign in to comment.