Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--net=host prevents su to jovyan user #64

Closed
parente opened this issue Nov 16, 2015 · 4 comments
Closed

--net=host prevents su to jovyan user #64

parente opened this issue Nov 16, 2015 · 4 comments

Comments

@parente
Copy link
Member

parente commented Nov 16, 2015

To overcome the problem in the title, need to set --pid=host as a workaround to moby/moby#5899. But then, tini reports:

[WARN ] Tini is not running as PID 1 and isn't registered as a child subreaper.
       Zombie processes will not be re-parented to Tini, so zombie reaping won't work.
       To fix the problem, use -s or set the environment variable TINI_SUBREAPER to register Tini as a child subreaper, or run Tini as PID 1.

To overcome this problem, tini needs to be started with -s. Maybe tini should always be started with -s in minimal-notebook?

@parente
Copy link
Member Author

parente commented Nov 19, 2015

Actually, I prefer not changing the tini default since the consequences are somewhat unknown. (The tini doc mentions a kernel version requirement, but maybe there's more?)

At any rate, this can be solved by simply setting the env var mentioned in the log message at docker run time:

docker run -it --rm --net=host --pid=host -e TINI_SUBREAPER=true jupyter/minimal-notebook

I think simply documenting this in the spark stacks that recommend running with --net=host is a good enough answer.

@jtyberg, you hit this. What do you think?

@jtyberg
Copy link
Member

jtyberg commented Nov 19, 2015

I want the reaping for sure, so if it's a choice between "-s" in the tini cmd and setting the TINI_SUBREAPER environment variable, I think I prefer the latter. It's more explicit, and clearer to the user what is going on.

@parente
Copy link
Member Author

parente commented Nov 21, 2015

I added the doc to pyspark and all-spark READMEs. Pushed directly to master since it's a doc only change.

@parente parente closed this as completed Nov 21, 2015
rochaporto pushed a commit to rochaporto/docker-stacks that referenced this issue Jan 23, 2019
Added option that allows self-signed ssl cert (for GitLab)
@dhinojosa
Copy link

Seven years later, I tried reading the documentation and this ticket and can't make sense of it. I created a topic here: https://discourse.jupyter.org/t/integrating-docker-stacks-with-spark-and-minio-as-s3/15958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants