Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nteract front end #1327

Closed
wants to merge 2 commits into from
Closed

Add nteract front end #1327

wants to merge 2 commits into from

Conversation

willpuckett
Copy link

@willpuckett willpuckett commented May 23, 2021

Add an option to use the nteract front end extension in docker-stacks containers. Additional conda forge package is 28MB.

The nteract front end provides a graphically clean front end interface ideal for both focused development and tidy presentations.

@willpuckett
Copy link
Author

I initially PR'ed this to the https://github.com/sakuraiyuta/docker-stacks fork as I intend to use this primarily on ARM, but given this discussion, as well as its hopeful utility to others, I thought it might make more sense upstream.

@mathbunnyru
Copy link
Member

mathbunnyru commented May 23, 2021

Hi @willpuckett!

We've started to encourage fewer additions to the images here and more contributions to the recipes in the documentation (http://jupyter-docker-stacks.readthedocs.io/en/latest/using/recipes.html).

I think a recipe about how to add and configure nteract would make sense in the docs, if you would like to change PR (http://jupyter-docker-stacks.readthedocs.io/en/latest/contributing/recipes.html).

Also, as far as I understand, was last released on Jul 16, 2019, so the package is not updated anymore.
And it seems, that there is a deprecation plan.
nteract/nteract#5088 (comment)
So, I would rather see this as a recipe than adding to the base image.

Copy link
Member

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented above the reason for changes

@willpuckett
Copy link
Author

Thanks Ayaz. I think that's more appropriate as well.

Cheers,
WP

@mathbunnyru mathbunnyru marked this pull request as draft May 24, 2021 19:51
@mathbunnyru
Copy link
Member

Converting to a draft till it's redone using the recipe approach.

@willpuckett
Copy link
Author

Closing this. The process for a child image is already well documented, and documenting a deprecated package seems unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants