Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] - Proof of concept - optimising CI build #1627

Closed
wants to merge 16 commits into from

Conversation

trallard
Copy link
Member

@trallard trallard commented Feb 15, 2022

Related to #1407

Note this is still very in WIP - but wanted to get a PR in to share with you all what I am thinking/working on

Notes:

  • I am moving away from Make to using doit some of the advantages of this are:
    • Python-based so we get all the syntactic sugar
    • it allows for much more flexibility when it comes to set tasks, dependencies, and manipulating artefacts/build outputs
    • others projects in the Jupyter ecosystem have started adopting it for automation and to complement their CI workflows and it works pretty well

What I have done:

  • started to adopt the workflow shown in Improve performance of CI system #1407
  • added cache for the Docker build and for Python dependencies
  • note that to reduce times and points of failure (plus getting a small POC I am currently only building + testing base-notebook)
  • I have to do some debugging since when I run the GitHub actions workflow locally with act all the tests are working fine and passing, but when ran in GH actions they all seem to fail
    • Also the manifest creation is failing 🤷🏽 but will also need to debug ]

@mathbunnyru
Copy link
Member

@trallard please ping me when this is ready to be reviewed or you need some help.

@trallard trallard closed this Feb 16, 2022
@trallard trallard deleted the trallard/docker-paralel-build branch February 16, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants