Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix English typos and misc details detected by PyCharm #1656

Merged
merged 4 commits into from Mar 16, 2022

Conversation

mathbunnyru
Copy link
Member

Sometimes I like to use PyCharm to write python/markdown code.
So I decided to fix some issues to not to see them anymore.

This PR doesn't fix all the issues, though, but I think the remaining ones are not actually issues and they have to do with some our internal names like jovyan.

docs/using/recipes.md Outdated Show resolved Hide resolved
tagging/taggers.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions, if resolved - this LGTM!

I hope you don't mind me updating the PR description, I couldn't understand what "Fix PyCharm issues" meant. Initially I thought you had issues working with the code base with PyCharm.

@consideRatio consideRatio changed the title Fix PyCharm issues Fix english typos and misc details detected by PyCharm Mar 16, 2022
@consideRatio consideRatio changed the title Fix english typos and misc details detected by PyCharm Fix English typos and misc details detected by PyCharm Mar 16, 2022
Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
@mathbunnyru
Copy link
Member Author

Sure, feel free to update anything that is not clear :)

@mathbunnyru mathbunnyru reopened this Mar 16, 2022
@mathbunnyru mathbunnyru merged commit 53fa575 into jupyter:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants