Various tuneups #217
Merged
Various tuneups #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some makefile cleanup too (c) Copyright IBM Corp. 2016
Prevent docker from creating the ~/.local/share/jupyter directory as rw for root only. Otherwise notebook can’t create runtime/ and other import subduers (c) Copyright IBM Corp. 2016
Ref jupyter#188 (c) Copyright IBM Corp. 2016
Ref jupyter#188 (c) Copyright IBM Corp. 2016
Fixes jupyter#123 (c) Copyright IBM Corp. 2016
| @@ -49,7 +50,7 @@ USER jovyan | |||
| # Setup jovyan home directory | |||
| RUN mkdir /home/$NB_USER/work && \ | |||
| mkdir /home/$NB_USER/.jupyter && \ | |||
| mkdir /home/$NB_USER/.local && \ | |||
| mkdir -p -m 700 /home/$NB_USER/.local/share/jupyter && \ | |||
There was a problem hiding this comment.
why does this directory need to be created manually?
There was a problem hiding this comment.
If a user follows the directions in the readme to host mount a ssl certificate where we have preconfigured the notebook server to look for it, docker creates the intervening directories with root ownership and read only permissions. This effectively prevents the notebook server from writing other files into this directory like the notebook signing key and breaks everything.
We could change the notebook config to look for the pem file in another directory and break backward compatibility with older images. I opted for keeping the file where it has been and making the subdirectories ahead of time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a handful in one PR to avoid multiple costly rebuilds.
Based on PR #216 so that the tests run on travis post build. Merge that PR before this one.