fixing content root notebook problem #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
what are we supposed to look at? There is no image in this link? Or am I missing something ... |
|
It shouldn't look any different, which is the main thing to check for. This is just fixing a bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I dug into the content root image problem, and I think this fixes it with a bit less code than @BENR0 's implementation in #141 . That implementation works well too! But we were slow in getting it merged and some of the build script had changed, so it seemed good to start fresh.
I added a test to make sure that the image path is correct if the notebook is in the root of the content folder. Nothing else should have changed in the user-facing docs. How does it look?
Here's how it looks: https://1015-137292803-gh.circle-artifacts.com/0/html/intro.html