Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from using this as the JupyterLab basis #19

Merged
merged 5 commits into from Nov 28, 2017

Conversation

blink1073
Copy link
Member

This was created as part of jupyterlab/jupyterlab#3270. It uses some patterns from the ipython version.

  • adds enhanced support for npm and auto-detection of yarn.
  • adds support for ** glob patterns in data_files and package_data.
  • adds functions to ensure the python version and get the package version.
  • adds a convenience function to create a Command that calls a callback when run
  • general cleanup

@blink1073
Copy link
Member Author

cf https://github.com/vidartf/opinionated-widget-cookiecutter/pull/3 for another usage of the same file

@vidartf
Copy link
Collaborator

vidartf commented Nov 28, 2017

LGTM 👍

@blink1073 blink1073 merged commit 0f61337 into jupyter:master Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants