Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release new PyPi version #106

Closed
chrisjsewell opened this issue Mar 7, 2020 · 10 comments
Closed

Release new PyPi version #106

chrisjsewell opened this issue Mar 7, 2020 · 10 comments

Comments

@chrisjsewell
Copy link
Contributor

chrisjsewell commented Mar 7, 2020

Hey @akhmerov could you release a new version, so that I can use it to release MyST-NB thanks 馃槃

@akhmerov
Copy link
Member

akhmerov commented Mar 7, 2020

You need this because of #103, right?

@chrisjsewell
Copy link
Contributor Author

Yep 馃憤 and the rest of the commits that @choldgraf has made

@akhmerov
Copy link
Member

akhmerov commented Mar 7, 2020

What do you mean? #103 is the only change on this side IIRC.

I'm wondering if the release is better to time with the changes to the AST structure, and incorporating the CellOutputNote logic like done in ebp. (CC @choldgraf)

@chrisjsewell
Copy link
Contributor Author

chrisjsewell commented Mar 7, 2020

What do you mean? #103 is the only change on this side IIRC.

Yeh my bad, I didn't notice it was a merge commit

I'm wondering if the release is better to time with the changes to the AST structure, and incorporating the CellOutputNote logic like done in ebp. (CC @choldgraf)

In this first instance, the purpose here is purely to generate a baseline MyST-NB distributed version that people can install/use for testing and feedback (rather than just downloading from master, that is liable to change). Just an alpha pre-release would be fine.

@choldgraf
Copy link
Contributor

Agreed that we want to make some more changes (like the AST stuff) but I'm +1 on a minor release to trigger a chain of other releases haha

@akhmerov
Copy link
Member

akhmerov commented Mar 7, 2020

I've made https://pypi.org/project/jupyter-sphinx/0.2.4a1/ does this work for you?

@chrisjsewell
Copy link
Contributor Author

I've made https://pypi.org/project/jupyter-sphinx/0.2.4a1/ does this work for you?

馃憣 thanks

@chrisjsewell
Copy link
Contributor Author

FYI, you probably already know, but you can get Travis to auto-deploy to PyPi when you create a new release; as I do in Myst-Parser: https://github.com/ExecutableBookProject/MyST-Parser/blob/40b4de4bdfd76b79a16e8b8a15f613dd85238176/.travis.yml#L41

@akhmerov
Copy link
Member

akhmerov commented Mar 7, 2020

I do, but I didn't get around to set it up properly. Since I manage unrelated projects, it'd be prudent to not use the same account for all uploads. Plus I am on the fence wrt storing keys on third party infrastructure.

I'm going to close the issue as addressed. Feel free to reopen if you need something.

@akhmerov akhmerov closed this as completed Mar 7, 2020
@choldgraf
Copy link
Contributor

Many thanks @akhmerov! I'll try and return the favor by making some PRs in the coming days 馃槉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants