-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactoring into submodules #103
Conversation
Wouldn't an Otherwise backwards compatibility breaking would also be OK, but then I'd like to go sure that also the directives and the AST are stabilized before making a release. |
ah good call - I just added a commit that is a little bit hacky, but I think accomplishes the same thing. Also added a deprecation warning. WDYT? I'm not sure how to test both the old and new way... |
I just cleaned up the imports a bit (so they are more well-ordered) and ran |
Thanks a lot! |
woo - OK I'll try and upstream some more stuff this week |
This refactors jupyter_sphinx into a few submodules:
ast.py
execute.py
thebelab.py
utils.py
and puts the sphinx
setup()
function in__init__.py
.the docs build and the tests pass for me. I still want to clean up the imports, and apply a
black
pass, but wanted to see if this looks reasonable to others first. If folks are +1 on this, then I'll add another commit that cleans up the import statements, and applies "black" and ensures a flake8 test passes.The one user-facing change is that the extension will now be loaded with
jupyter_sphinx
instead ofjupyter_sphinx.execute
. Perhaps there's a way we could import one into the other to temporarily keep both behaviors?