Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website broken on narrow screens #102

Closed
Carreau opened this issue Jun 7, 2016 · 13 comments
Closed

Website broken on narrow screens #102

Carreau opened this issue Jun 7, 2016 · 13 comments
Assignees

Comments

@Carreau
Copy link
Member

Carreau commented Jun 7, 2016

Content is hidden.

screen shot 2016-06-06 at 21 05 29

There should:

  • be test that the navbar is not wider than XXX.
  • logo should collapse on small screen. Svg can be responsive
  • be test that the navbar is not wider than XXX.
  • be test that the navbar is not wider than XXX.
@Carreau
Copy link
Member Author

Carreau commented Jun 7, 2016

@ellisonbg when are your summer student working ? Do you have a specific tag for thing you want them to work on ?

@ellisonbg
Copy link
Collaborator

They start next week full time. Initially I am giving them medium sized
projects that will last about a week on JupyterLab and the website. This
will expand to cover the docs, ipywidgets and notebook as well. They are
initially spending a lot of time just learning as well...

On Mon, Jun 6, 2016 at 9:22 PM, Matthias Bussonnier <
notifications@github.com> wrote:

@ellisonbg https://github.com/ellisonbg when are your summer student
working ? Do you have a specific tag for thing you want them to work on ?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#102 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AABr0P0N2Scm9Vi5hcfwTGmYTy2ultGOks5qJPIggaJpZM4Ivifo
.

Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
bgranger@calpoly.edu and ellisonbg@gmail.com

@Carreau
Copy link
Member Author

Carreau commented Jun 8, 2016

Great, feel free to ping me, I think we can do a better job this year if we get early good habit.
We could need to write a custom Sphinx directive for the jupyter doc. Would that be a "small" project ?

@ellisonbg
Copy link
Collaborator

What type of sphinx directive? In other words, what would it do?

On Wed, Jun 8, 2016 at 9:52 AM, Matthias Bussonnier <
notifications@github.com> wrote:

Great, feel free to ping me, I think we can do a better job this year if
we get early good habit.
We could need to write a custom Sphinx directive for the jupyter doc.
Would that be a "small" project ?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#102 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AABr0Ahd8X3ryg0oCXiU15d5pTwNKMcRks5qJvNIgaJpZM4Ivifo
.

Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
bgranger@calpoly.edu and ellisonbg@gmail.com

@Carreau
Copy link
Member Author

Carreau commented Jun 8, 2016

What type of sphinx directive? In other words, what would it do?

Hum, long to describe... in 2 words:

Take a yaml-like (or whatever) structure and render the content of this page, which right now is hardcodded as html which prevent cross-linking, force duplication of templates with 1 word change in all of them with jupyter-sphinx-themes, as well as a few other drawbacks.

If yes I can make a longer description.

@ellisonbg
Copy link
Collaborator

Fernando, Carol, Jamie and I talked yesterday about some docs stuff.
@willingc is going to try to consolidate the build of our docs into a
single repo using git submodules - might solve some of these issues. But
yes, this type of thing might be within scope for the students eventually.

On Wed, Jun 8, 2016 at 10:02 AM, Matthias Bussonnier <
notifications@github.com> wrote:

What type of sphinx directive? In other words, what would it do?

Hum, long to describe... in 2 words:

Take a yaml-like (or whatever) structure and render the content of this
page http://jupyter.readthedocs.io/en/latest/, which right now is
hardcodded as html which prevent cross-linking, force duplication
https://github.com/jupyter/jupyter/tree/master/docs/source/_templates
of templates
https://github.com/jupyter/jupyter-sphinx-theme/tree/master/jupyter_sphinx_theme/jupyter
with 1 word change in all of them with jupyter-sphinx-themes, as well as a
few other drawbacks.

If yes I can make a longer description.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#102 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AABr0GHF-nwkn81mCSUkwsMjnGBbYhVrks5qJvXDgaJpZM4Ivifo
.

Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
bgranger@calpoly.edu and ellisonbg@gmail.com

@Carreau
Copy link
Member Author

Carreau commented Jun 8, 2016

Fernando, Carol, Jamie and I talked yesterday about some docs stuff.

is that somewhere ?

@willingc is going to try to consolidate the build of our docs into a
single repo using git submodules

I think subtree might be an alternative, and I'm a bit unsure why submodules.
Travis might be able to consolidate docs in one place though.

But
yes, this type of thing might be within scope for the students eventually.

Do you want me to (try to) make a longer description ?

@ellisonbg
Copy link
Collaborator

Can you sync up with @willingc to see how her experiment with
subtrees/submobules relates to this?

On Wed, Jun 8, 2016 at 10:52 AM, Matthias Bussonnier <
notifications@github.com> wrote:

Fernando, Carol, Jamie and I talked yesterday about some docs stuff.

is that somewhere ?

@willingc https://github.com/willingc is going to try to consolidate
the build of our docs into a
single repo using git submodules

I think subtree might be an alternative, and I'm a bit unsure why
submodules.
Travis might be able to consolidate docs in one place though.

But
yes, this type of thing might be within scope for the students eventually.

Do you want me to (try to) make a longer description ?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#102 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AABr0Hm1f9s81aBcnNrGze2Z_qSkyPLdks5qJwFHgaJpZM4Ivifo
.

Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
bgranger@calpoly.edu and ellisonbg@gmail.com

@Carreau
Copy link
Member Author

Carreau commented Jun 8, 2016

Sure.

@Carreau Carreau self-assigned this Jun 8, 2016
@willingc
Copy link
Member

willingc commented Jun 8, 2016

@Carreau @ellisonbg I have started tagging some issues in different repos as sprint-friendly:calpoly. Most are docs issues for now but I'm curating issues for a SciPy sprint or the interns to work on as time permits.

@willingc willingc self-assigned this Jun 8, 2016
@willingc
Copy link
Member

willingc commented Jun 8, 2016

@Carreau I assigned myself as well here as a reminder to sync up with you on alternative builds of the docs. Doing some research today and tomorrow of some of the large docs projects (sentry, mozilla, openstack, django) to see which use submodules or subtrees. If you have 30 minutes on Friday for a webchat, we can talk about what I find.

@cameronoelsen
Copy link
Contributor

@Carreau This doesn't seem to be a problem anymore (I believe I made a fix earlier in the year). Are you still experiencing it? We are also going to be pushing a reworking of the navigation in the next few weeks.

@Carreau
Copy link
Member Author

Carreau commented Aug 10, 2017

screen shot 2017-08-10 at 10 31 42

No it's better it's still off when exactly at 768px width. You have another funky double transition at 991px -> 992px and 992px -> 993px, but that's in bootstrap.min.css so I doubt you can do anything about these. feel free to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants