Session.msg_id optimization #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use session_id and message counter. This gives a unique id but uses much less time
|
Great! |
|
This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was benchmarking the ipyparallel code and discovered that the scripts where spending a lot of time acquiring msg_ids.
The msg_id property of the Session class takes a while to run just to get a unique ID.
To optimise this I changed the msg_id property function to use a message counter and to just return the session_id + message count. This also return a unique ID and runs much faster.
Using timeit to compare the existing code with my implementation I got these runtimes for 1000 000 calls to session.msg_id: