Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin jedi #615

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Unpin jedi #615

merged 2 commits into from
Feb 18, 2021

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Feb 2, 2021

Now that IPython 7.20 is out, the jedi pin should no longer be needed 馃帀

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Feb 2, 2021

Ah, of course, this wouldn't fix 3.6, as 7.20 is 3.7+...

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Feb 2, 2021

So... what's the story behind no windows testing, if i might ask?

@bollwyvl bollwyvl mentioned this pull request Feb 2, 2021
Merged
4 tasks
kevin-bates
kevin-bates approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess I would have expected ipython to enforce the conditional management of jedi versions, but I suppose this will ensure that happens.

@kevin-bates
Copy link
Member

So... what's the story behind no windows testing, if i might ask?

Looks like these were stopped via #586, but are being revived by #613. The problem is that they all appear to hang after the tests have completed.

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Feb 2, 2021

ipython to enforce the conditional management of jedi versions

IPython no longer supports <py3.7, and the last released version does not have a top pin. but let's not drag that beast out any longer.

hang after the tests have completed.

GAAAAH. that's rough... hooray for progress, though. will take a gander.

@vidartf vidartf mentioned this pull request Feb 8, 2021
Closed
@kevin-bates kevin-bates merged commit 959fa6e into jupyter:master Feb 18, 2021
@Carreau Carreau modified the milestones: 6.1.11, 6.1.12 Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-bates kevin-bates kevin-bates approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1.12
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bollwyvl @kevin-bates @Carreau