Rename trait to allowed_kernelspecs #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-bates
reviewed
Aug 4, 2021
There was a problem hiding this comment.
The changes look good Steve, thank you for providing this. I just had a couple of comments. I've run with this branch and see the appropriate deprecation warning:
[W 14:52:14.292 NotebookApp] KernelSpecManager.whitelist is deprecated in JupyterLab 7.0, use KernelSpecManager.allowed_kernel_names instead
My first thought on the trait name was allowed_kernels but I think allowed_kernel_names is more correct. I suppose another option would be allowed_kernelspecs so that kernel names aren't accidentally interpreted as "ipykernel" or "xeus-python", etc. i.e., the literal kernel name.
Co-authored-by: Kevin Bates <kbates4@gmail.com>
Co-authored-by: Kevin Bates <kbates4@gmail.com>
kevin-bates
reviewed
Aug 5, 2021
Co-authored-by: Kevin Bates <kbates4@gmail.com>
Co-authored-by: Kevin Bates <kbates4@gmail.com>
Co-authored-by: Kevin Bates <kbates4@gmail.com>
Co-authored-by: Kevin Bates <kbates4@gmail.com>
blink1073
changed the title
Co-authored-by: Kevin Bates <kbates4@gmail.com>
Co-authored-by: Kevin Bates <kbates4@gmail.com>
|
Thanks! I updated the title and description accordingly. |
Did we release Jupyterlab 7 already??? 😮 🎉 |
Merged
Haha fixes are welcome. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #642 by deprecating
KernelSpecManager.whitelistin favor of the more descriptive and inclusiveKernelSpecManager.allowed_kernelspecs.