Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow kwargs when writting connection_file #953

Merged
merged 5 commits into from Jun 23, 2023

Conversation

fecet
Copy link
Contributor

@fecet fecet commented Jun 21, 2023

Allow writing user-relevant information when creating a connection file. As an example, this can fulfill my feature request jupyter/notebook#6936.

Should be work with ipython/ipykernel#1127

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@blink1073 blink1073 enabled auto-merge (squash) June 23, 2023 10:01
@blink1073 blink1073 changed the title feat: allow kwargs when writting connection_file Allow kwargs when writting connection_file Jun 23, 2023
@blink1073 blink1073 merged commit bddb885 into jupyter:main Jun 23, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants