Better indication of whether image data was handled. #77

takluyver · 2016-06-01T11:31:48Z

flying-sheep · 2016-06-01T11:37:00Z

jupyter_console/ptshell.py

@@ -708,22 +708,22 @@ def handle_iopub(self, msg_id=''):
    def handle_rich_data(self, data):
        for mime in self.mime_preference:
            if mime in data and mime in self._imagemime:
-                self.handle_image(data, mime)
-                return True
+                return self.handle_image(data, mime)


we don’t want to return False if one mime can’t be handled. maybe the next can?

flying-sheep · 2016-06-01T12:13:24Z

hmm, we have to merge our PRs based on what we did differently:

i have amended the docs, you didn’t. i think it’s good to document what callable_image_handler’s return value means
you chose to only accept False as callable_image_handler’s return value to indicates failure, i also accept other falsey things apart from None
i use the less configurable but more robust show

takluyver · 2016-06-01T12:55:34Z

Updated the docs and used ImageShow.

flying-sheep · 2016-06-01T12:57:41Z

looks good!

minrk · 2016-06-01T13:24:55Z

Thanks for reviewing, @flying-sheep!

Better indication of whether image data was handled.

93483a0

Closes jupytergh-71

takluyver mentioned this pull request Jun 1, 2016

console does not display text/plain alternative for display_data? #71

Closed

flying-sheep reviewed Jun 1, 2016
View reviewed changes

Improve based on flying-sheep's suggestions

9908330

flying-sheep and others added 2 commits June 1, 2016 13:52

Use PIL.ImageShow module to return whether image was shown successfully

d5d6610

Document return value of callable_image_handler

f90e3c0

flying-sheep mentioned this pull request Jun 1, 2016

Use fallback handlers for display data #78

Closed

minrk merged commit 49740dc into jupyter:master Jun 1, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better indication of whether image data was handled. #77

Better indication of whether image data was handled. #77

takluyver commented Jun 1, 2016

flying-sheep Jun 1, 2016

flying-sheep commented Jun 1, 2016 •

edited

takluyver commented Jun 1, 2016

flying-sheep commented Jun 1, 2016

minrk commented Jun 1, 2016

Better indication of whether image data was handled. #77

Better indication of whether image data was handled. #77

Conversation

takluyver commented Jun 1, 2016

flying-sheep Jun 1, 2016

Choose a reason for hiding this comment

flying-sheep commented Jun 1, 2016 • edited

takluyver commented Jun 1, 2016

flying-sheep commented Jun 1, 2016

minrk commented Jun 1, 2016

flying-sheep commented Jun 1, 2016 •

edited