properly handle unicode characters in home dirs #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You don't need to open new PRs. You can update the existing ones by pushing new versions of a change to the existing branch using Nevertheless, I don't think this is the correct fix. Can you post the full traceback and exception you get when trying to run the migrate script? |
vit-tucek
force-pushed
the
unicode_home_dirs
branch
from
bda3aca
to
7bfb04c
Compare
vit-tucek
force-pushed
the
unicode_home_dirs
branch
from
7bfb04c
to
f1e18b8
Compare
vit-tucek
force-pushed
the
unicode_home_dirs
branch
2 times, most recently
from
903a62d
to
7fbd069
Compare
|
This could probably be updated to work the same as jupyter/notebook#3664. |
vit-tucek
force-pushed
the
unicode_home_dirs
branch
from
7fbd069
to
e86688e
Compare
vit-tucek
force-pushed
the
unicode_home_dirs
branch
from
e86688e
to
47c4102
Compare
|
Done. Now if only the devs would notice. |
mistaken copy/paste from notebook
|
Sorry for the delay on this one. Merged with a small fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes users have home directories that contain unicode characters outside of ASCII (such as č). This leads to exception thrown in
migrate.py:migratenamely in the line:dst = dst_t.format(**env)because
jupyter_config_dirandjupyter_data_dirdo not return unicode.