Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable system-wide installations of Jupyter possible at any path #139

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

jhgoebbert
Copy link

Extend the config paths with additional system paths from environment variable JUPYTER_CONFIG_PATH.

Motivation:
Currently Jupyter configurations are only searched at fixed system paths (sys.prefix/etc/jupyter, ...)
and jupyter_config_dir(), which is in the first place a config dir writable to the user.
For a system-wide installation of Jupyter, which is not installed at sys.prefix one needs to have the ability to add additional system config paths.

Copy link

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea! I am not familiar enough with the code to check implementation, however.

@jhgoebbert
Copy link
Author

You can find the same implementation already used for JUPYTER_PATH just a few lines above in the same file:
https://github.com/jupyter/jupyter_core/blob/master/jupyter_core/paths.py#L144

@minrk minrk merged commit 51185b8 into jupyter:master Oct 18, 2018
@minrk
Copy link
Member

minrk commented Oct 18, 2018

Makes sense, thanks!

@takluyver takluyver added this to the 4.5 milestone Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants