Tolerate execute bit on owner when writing file #173
Conversation
Some filesystems (CIFS) auto-enable execute bits on files. As a result, we should tolerate execute on owner (but only owner). Closes: jupyter#172
|
I won't be able to recheck this until next Wednesday. |
I can on Friday and then Tuesday... |
|
@hroncok, @MarekSuchanek - thank you! We will likely move forward with the merge, but should probably hold off on building a release until we know this looks okay. Thanks for your help! |
|
I've verified that this works. Thank You. |
There was a problem hiding this comment.
I can help get a patch release going for this @kevin-bates if you want to make the changelog entry.
|
@kevin-bates Done. |
|
This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there: https://discourse.jupyter.org/t/kernel-error-in-jupyter-notebook/4728/3 |
Some filesystems (CIFS) auto-enable execute bits on files. As
a result, we should tolerate execute on owner (but only owner).
Special thanks to @hroncok for providing the missing tidbits to this issue! (Pun intended)
Closes: #172